Fix NPC component cleanup #1175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #1160.
Problem
NPCs were not removed from the player pool during
NPCComponent::free, causing a crash.During shutdown, the NPC network is destroyed while NPCs remain in the player pool. Later, when textdraws are destroyed in
OnGameModeExit, a "hide textdraw" packet is sent to each player—including NPCs. This causes a crash when the packet is tried to be sent through the already-destroyed NPC network.Solution
Release all NPCs before destroying the component, ensuring they're removed from the player pool