Skip to content

Bugfix: Use sized initializers for the media sender cfg and callbacks - #7

Merged
ghbogarin merged 2 commits into
mainfrom
fix/moq5-sized-cfg-initializers
Aug 5, 2026
Merged

Bugfix: Use sized initializers for the media sender cfg and callbacks#7
ghbogarin merged 2 commits into
mainfrom
fix/moq5-sized-cfg-initializers

Conversation

@ghbogarin

@ghbogarin ghbogarin commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description:

The plugin compiled against the latest MOQ5 version was failing to publish video/audio due to mis-fired callbacks. Latest version of MOQ5 need sized initializers in order to work. As per docs of moq_media_sender_callbacks_init:

/* Pointer-only initializer: clears and stamps ONLY the frozen v0 prefix
 * (through on_subscriber_left). It cannot know the caller's storage size, so
 * it never touches the appended on_ready/on_closed/on_track_closed fields --
 * they stay disabled (struct_size == the v0 prefix). To SET any appended
 * callback, initialize with moq_media_sender_callbacks_init_sized(cb,
 * sizeof *cb) instead. */
MOQ_API void moq_media_sender_callbacks_init(moq_media_sender_callbacks_t *cb);


This change is Reviewable

@ghbogarin
ghbogarin merged commit e76b5bb into main Aug 5, 2026
3 of 6 checks passed
@ghbogarin
ghbogarin deleted the fix/moq5-sized-cfg-initializers branch August 5, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants