Skip to content

fix(api): fix lint for customer charge invoicing action - #5392

Merged
borbelyr-kong merged 1 commit into
mainfrom
fix/lint-customer-charge-invoicing
Oct 28, 2026
Merged

borbelyr-kong merged 1 commit into
mainfrom
fix/lint-customer-charge-invoicing

Conversation

@borbelyr-kong

@borbelyr-kong borbelyr-kong commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Fixes the customer-charge invoice test and Go import grouping.

  • Both invoicing tests call the method through the internal customer client.
  • The invoice handler keeps its existing logic with imports grouped for lint.

Reviews (1) · Last reviewed commit: "fix(api): fix lint for customer charge i..." · Reviewed by Greptile

Summary by CodeRabbit

  • Tests
    • Updated the nested-client test to call the invoice operation through the internal customer charges path. Expected results and URLs remain unchanged.
  • Chores
    • Reorganized an import statement; no runtime behavior changed.

@borbelyr-kong borbelyr-kong self-assigned this Oct 28, 2026
@borbelyr-kong borbelyr-kong added the release-note/misc Miscellaneous changes label Oct 28, 2026
@borbelyr-kong
borbelyr-kong requested a review from a team as a code owner October 28, 2026 13:04
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between da1a90c and 9cd32cd.

Files selected for processing: 3
  • api/spec/packages/aip-client-javascript/tests/nesting.spec.ts
  • api/spec/packages/typespec-typescript/templates/tests/nesting.spec.ts
  • api/v3/handlers/billinginvoices/invoice_charges.go

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The nesting tests now call the invoice operation through sdk.internal.customers.charges. The lo import in the Go invoice charges handler moves within its import block.

Changes: SDK nesting tests

Layer / File(s) Summary
Update nested-client test paths
api/spec/packages/aip-client-javascript/tests/nesting.spec.ts, api/spec/packages/typespec-typescript/templates/tests/nesting.spec.ts
Both tests use sdk.internal.customers.charges for the invoice operation. Their expected results and URLs remain unchanged.

Go import reorder

Layer / File(s) Summary
Move lo import
api/v3/handlers/billinginvoices/invoice_charges.go
The lo import moves within the import block. Runtime behavior does not change.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related PRs

Suggested labels: area/api, release-note/ignore

Suggested reviewers: turip

Merge Risk: Minimal · up to 9cd32

No actionable merge-blocking risk is identified in this PR.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies a lint fix for the customer charge invoicing action. This matches the stated objective and the related test and import changes.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@borbelyr-kong
borbelyr-kong enabled auto-merge (squash) October 28, 2026 13:06
@borbelyr-kong
borbelyr-kong merged commit ee44d4c into main Oct 28, 2026
37 of 39 checks passed
@borbelyr-kong
borbelyr-kong deleted the fix/lint-customer-charge-invoicing branch October 28, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/misc Miscellaneous changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants