8376338: Test7005594.sh fails when given a memory value with decimals

[adamfarley]

Because right now it cannot, due to bash arithmetic limitations.

Requesting a merge directly into jdk8u-dev because this file is not present in later versions, and cannot be backported.

https://bugs.openjdk.org/browse/JDK-8376338

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8376338 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8376338: Test7005594.sh fails when given a memory value with decimals (Bug - P4 - Approved)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/751/head:pull/751
$ git checkout pull/751

Update a local copy of the PR:
$ git checkout pull/751
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/751/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 751

View PR using the GUI difftool:
$ git pr show -t 751

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/751.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back afarley! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@adamfarley This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8376338: Test7005594.sh fails when given a memory value with decimals

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 6926a46: 8376225: [8u] GHA: Apply work-around for missing JNF for MacOSX builds
• 7d76001: 8376352: [8u] Build failure on Windows 32-bit after JDK-8362308
• ffdc8d8: 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (860d92d7)

[jerboaa]

@adamfarley Please enable GHA testing on your fork. See: https://github.com/openjdk/jdk8u-dev/pull/751/checks?check_run_id=61488376746

[adamfarley]

@adamfarley Please enable GHA testing on your fork. See: https://github.com/openjdk/jdk8u-dev/pull/751/checks?check_run_id=61488376746

Done. Good spot.

[jerboaa]

Also see the "Integration Blocker" message from the bot.

[adamfarley]

Is there a way to run tests again, now that actions are enabled? I'm not seeing a check or test option in the list of PR commands.

[jerboaa]

Is there a way to run tests again, now that actions are enabled? I'm not seeing a check or test option in the list of PR commands.

You should be able to run a test manually when going to: https://github.com/adamfarley/jdk8u-dev/actions/workflows/submit.yml (using your branch). Or merge master and push (if there are changes).

[adamfarley]

Is there a way to run tests again, now that actions are enabled? I'm not seeing a check or test option in the list of PR commands.

You should be able to run a test manually

Gotcha. Running now: https://github.com/adamfarley/jdk8u-dev/actions/runs/21434937551

FYI: This works for me locally, though I agree public testing is the way to go.

[jerboaa]

OK.

[openjdk]

⚠️ @adamfarley This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[adamfarley]

/approval

[openjdk]

@adamfarley usage: /approval [<id>] (request|cancel) [<text>]

[adamfarley]

/approval 8376338 request

[openjdk]

@adamfarley
8376338: The approval request has been created successfully.

[jerboaa]

/approval 8376338 request

Please use an appropriate text. The fix request comment is empty. See: https://openjdk.org/projects/jdk-updates/approval.html

[adamfarley]

/approval 8376338 request This fix allows compiler test script Test7005594.sh to accommodate test machines where the memory value is not a whole number by removing any decimal points and the numbers after it. So 123.456 becomes 123 only.

[openjdk]

@adamfarley
8376338: The approval request has been updated successfully.

[adamfarley]

I didn't mention if the patch applies cleanly because this isn't a backport from the JDK project.

[adamfarley]

/integrate

[openjdk]

@adamfarley
Your change (at version 860d92d) is now ready to be sponsored by a Committer.

[jerboaa]

/sponsor

[openjdk]

Going to push as commit e5dd8fa.
Since your change was applied there have been 3 commits pushed to the master branch:

• 6926a46: 8376225: [8u] GHA: Apply work-around for missing JNF for MacOSX builds
• 7d76001: 8376352: [8u] Build failure on Windows 32-bit after JDK-8362308
• ffdc8d8: 8360869: jcstress is able to crash jdk8 on aarch64 with jfr on

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa @adamfarley Pushed as commit e5dd8fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[adamfarley]

Thanks @jerboaa 😎