Skip to content

8378218: MSYS2 reports cygwin triplet causing bash configure failure#2642

Closed
tabata-d wants to merge 1 commit intoopenjdk:masterfrom
tabata-d:backport-tabata-d-feecb042-master
Closed

8378218: MSYS2 reports cygwin triplet causing bash configure failure#2642
tabata-d wants to merge 1 commit intoopenjdk:masterfrom
tabata-d:backport-tabata-d-feecb042-master

Conversation

@tabata-d
Copy link
Copy Markdown
Member

@tabata-d tabata-d commented Feb 26, 2026

Hi all,

This pull request contains a backport of commit feecb042 from the openjdk/jdk repository.

The commit being backported was authored by Daishi Tabata on 20 Feb 2026 and was reviewed by Erik Joelsson.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8378218 needs maintainer approval

Issue

  • JDK-8378218: MSYS2 reports cygwin triplet causing bash configure failure (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2642/head:pull/2642
$ git checkout pull/2642

Update a local copy of the PR:
$ git checkout pull/2642
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2642/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2642

View PR using the GUI difftool:
$ git pr show -t 2642

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2642.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Feb 26, 2026

👋 Welcome back dtabata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 26, 2026

@tabata-d This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8378218: MSYS2 reports cygwin triplet causing bash configure failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0643296: 8287062: com/sun/jndi/ldap/LdapPoolTimeoutTest.java failed due to different timeout message

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk Bot changed the title Backport feecb042fe4abbb9bb3aa9324de4e40393e03ae1 8378218: MSYS2 reports cygwin triplet causing bash configure failure Feb 26, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 26, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 26, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 26, 2026

⚠️ @tabata-d This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Feb 26, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Feb 26, 2026

Webrevs

@openjdk openjdk Bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 26, 2026
@tabata-d
Copy link
Copy Markdown
Member Author

/integrate

@openjdk openjdk Bot added the sponsor Pull request is ready to be sponsored label Feb 28, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Feb 28, 2026

@tabata-d
Your change (at version 2f5d1ab) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Copy Markdown
Member

/sponsor

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 2, 2026

Going to push as commit 818dd7f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9945500: 8377905: gcc.md included with every build
  • 0643296: 8287062: com/sun/jndi/ldap/LdapPoolTimeoutTest.java failed due to different timeout message

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Mar 2, 2026
@openjdk openjdk Bot closed this Mar 2, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 2, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Mar 2, 2026

@phohensee @tabata-d Pushed as commit 818dd7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tabata-d tabata-d deleted the backport-tabata-d-feecb042-master branch March 3, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants