8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently by rm-gh-8 · Pull Request #2636 · openjdk/jdk21u-dev

rm-gh-8 · 2026-02-24T20:52:43Z

Backporting JDK-8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently.

This PR migrates tests from a closed repository with improvements including corrected thread logic, paint-on-demand behavior, and support for all systems (not just OpenGL).

For parity with Oracle JDK. Already backported to 25.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/jdk/sun/java2d/OpenGL/DrawBitmaskImage.java
make test TEST=test/jdk/sun/java2d/OpenGL/DrawBufImgOp.java
make test TEST=test/jdk/sun/java2d/OpenGL/DrawImageBg.java
make test TEST=test/jdk/sun/java2d/OpenGL/LargeOps.java
make test TEST=test/jdk/sun/java2d/OpenGL/OpaqueDest.java
make test TEST=test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java
make test TEST=test/jdk/sun/java2d/OpenGL/ShapeClip.java
make test TEST=test/jdk/sun/java2d/OpenGL/SrcMaskOps.java
make test TEST=test/jdk/sun/java2d/OpenGL/VolatileSubRegion.java
make test TEST=test/jdk/sun/java2d/OpenGL/XformVolatile.java

Note: test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java fails. Issues related to JDK-8369335 (#2644) and JDK-8378113 (#2645) will be addressed in separate dependent backport PRs.

For this backport to 21, test/jdk/sun/java2d/OpenGL/DrawBitmaskImage.java also fails. This doesn't occur on tip, 26 and 25, which is likely due to a bug in 21. Created JDK-8378788 to report the issue and JDK-8378789 (#2646) to add it to the problem list.

Results attached:

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8358058 needs maintainer approval

Issue

JDK-8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2636/head:pull/2636
$ git checkout pull/2636

Update a local copy of the PR:
$ git checkout pull/2636
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2636/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2636

View PR using the GUI difftool:
$ git pr show -t 2636

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2636.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-02-24T21:05:03Z

👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-02-24T21:05:37Z

@rm-gh-8 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

7f14687: 8373704: Improve "SocketException: Protocol family unavailable" message
f95246e: 8374711: Hotspot runtime/CommandLine/OptionsValidation/TestOptionsWithRanges fails without printing the option name
33109d6: 8378353: [PPC64] StringCoding.countPositives causes errors when the length is not a proper 32 bit int
... and 16 more: https://git.openjdk.org/jdk21u-dev/compare/493ec0e379559df72bd5c5e1a3632e8615eb522e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2026-02-24T21:05:54Z

This backport pull request has now been updated with issue from the original commit.

openjdk · 2026-02-24T21:20:45Z

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

mlbridge · 2026-02-24T21:24:40Z

Webrevs

00: Full (1f4ed1b7)

rm-gh-8 · 2026-02-26T21:18:54Z

/approval request for backport of JDK-8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently.

This is a test fix.

For parity with Oracle JDK.

Note: test/jdk/sun/java2d/OpenGL/ScaleParamsOOB.java fails. Issues related to JDK-8369335 (#2644) and JDK-8378113 (#2645) will be addressed in separate dependent backport PRs.

For this backport to 21, test/jdk/sun/java2d/OpenGL/DrawBitmaskImage.java also fails. This doesn't occur on tip, 26 and 25, which is likely due to a bug in 21. Created JDK-8378788 to report the issue and JDK-8378789 (#2646) to add it to the problem list.

openjdk · 2026-02-26T21:30:41Z

@rm-gh-8
8358058: The approval request has been created successfully.

GoeLin · 2026-02-27T19:21:10Z

Hi @rm-gh-8
I added fix-request and fix-yes to https://bugs.openjdk.org/browse/JDK-8378789, too.
Please make sure you push this and all follow-ups at the same time, so that they are either
pushed before or after Tuesday 3rd, 18:00 CET. That's the date of split between 21.011 and 21.0.12.

rm-gh-8 · 2026-02-27T19:26:45Z

@GoeLin I will push all related PRs after Tuesday 3rd, 18:00 CET.

rm-gh-8 · 2026-03-10T13:39:31Z

/integrate

openjdk · 2026-03-10T13:40:53Z

@rm-gh-8
Your change (at version 1f4ed1b) is now ready to be sponsored by a Committer.

simonis · 2026-03-10T14:43:47Z

/sponsor

openjdk · 2026-03-10T14:47:38Z

Going to push as commit 4db322c.
Since your change was applied there have been 21 commits pushed to the master branch:

6a9865e: 8373832: Test java/lang/invoke/TestVHInvokerCaching.java tests nothing
149e02b: 8369851: Remove darcy author tags from langtools tests
7f14687: 8373704: Improve "SocketException: Protocol family unavailable" message
... and 18 more: https://git.openjdk.org/jdk21u-dev/compare/493ec0e379559df72bd5c5e1a3632e8615eb522e...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-03-10T14:47:48Z

@simonis @rm-gh-8 Pushed as commit 4db322c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Backport ebeb77b

1f4ed1b

openjdk Bot changed the title ~~Backport ebeb77baaeb6d9098d7462f5ddf61d8583b1e493~~ 8358058: sun/java2d/OpenGL/DrawImageBg.java Test fails intermittently Feb 24, 2026

openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 24, 2026

rm-gh-8 marked this pull request as ready for review February 24, 2026 21:19

openjdk Bot added the rfr Pull request is ready for review label Feb 24, 2026

openjdk Bot added the approval Requires approval; will be removed when approval is received label Feb 26, 2026

openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Feb 27, 2026

openjdk Bot added the sponsor Pull request is ready to be sponsored label Mar 10, 2026

openjdk Bot added the integrated Pull request has been integrated label Mar 10, 2026

openjdk Bot closed this Mar 10, 2026

openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2026

openjdk Bot removed the sponsor Pull request is ready to be sponsored label Mar 10, 2026

Conversation

rm-gh-8 commented Feb 24, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewing

Uh oh!

bridgekeeper Bot commented Feb 24, 2026

Uh oh!

openjdk Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented Feb 24, 2026

Uh oh!

openjdk Bot commented Feb 24, 2026

Uh oh!

mlbridge Bot commented Feb 24, 2026

Webrevs

Uh oh!

rm-gh-8 commented Feb 26, 2026

Uh oh!

openjdk Bot commented Feb 26, 2026

Uh oh!

GoeLin commented Feb 27, 2026

Uh oh!

rm-gh-8 commented Feb 27, 2026

Uh oh!

rm-gh-8 commented Mar 10, 2026

Uh oh!

openjdk Bot commented Mar 10, 2026

Uh oh!

simonis commented Mar 10, 2026

Uh oh!

openjdk Bot commented Mar 10, 2026

Uh oh!

openjdk Bot commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

rm-gh-8 commented Feb 24, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Feb 24, 2026 •

edited

Loading