Update default value for MHPMCounterNum to 10 - #338
Open
MikeOpenHWGroup wants to merge 1 commit into
Open
MikeOpenHWGroup wants to merge 1 commit into
MikeOpenHWGroup wants to merge 1 commit into
Conversation
As discussed in openhwfoundation#337
MikeOpenHWGroup
requested review from
IhsaneTahir
and
a balanced review from Copilot
September 30, 2026 13:36
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation now matches the RTL and configuration default of 10.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the integration documentation to match the core’s existing default configuration.
Changes:
- Changes the documented
MHPMCounterNumdefault from 0 to 10.
| File | Description |
|---|---|
doc/02_user/integration.rst |
Corrects the documented performance-counter default. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #337