fix(ans): reject invalid setRecentCount dump arg via from_chars - #1
Open
tonycoder-hub wants to merge 1 commit into
Open
fix(ans): reject invalid setRecentCount dump arg via from_chars#1tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
ShellDump setRecentCount used bare atoi, so non-numeric and partial inputs could become 0 (in-range) or a truncated value. Parse with digits-only from_chars and enforce [0,1024]. Signed-off-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShellDump
setRecentCount(AdvancedNotificationService::SetRecentNotificationCount) used bareatoion the dump argument before checking[NOTIFICATION_MIN_COUNT, NOTIFICATION_MAX_COUNT](0..1024).atoi("abc")/atoi("")become0(in range) and are silently accepted;atoi("12xyz")truncates to12. This PR parses with digits-onlystd::from_charsand rejects empty, non-digit, partial, and out-of-range values.Changes
services/ans/include/parse_recent_notification_count.hwithParseRecentNotificationCount(match miscservices_request parse helper style).SetRecentNotificationCount; drop the separate min/max if-check (parser already enforces[0, 1024]).Testing
Signed-off-by: Tony Coder 407243179@qq.com