fix: leftover resource id stoul abort - #4
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
GetResourceId matches [0-9]+ then stoul; a long all-digit resource id still throws and can abort ACE. Parse with from_chars and reject overflow/junk. Signed-off-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetResourceIdinjs_sceneview.cpp/component3d_modifier.cppmatchesresource://.../([0-9]+).extthen callsstd::stoul.[0-9]+is unbounded, so a long all-digit resource id still throwsstd::out_of_rangeand can abort ACE.from_charsand reject overflow/junk. Same leftover class as the already-hardenedimage_loader.cppdigit-length check.Test plan
parse_resource_uint32(g++ -std=c++17 -O0 -g -fsanitize=address,undefined): empty / junk / overflow /0/42/UINT32_MAXSigned-off-by: Tony Coder 407243179@qq.com