Skip to content

fix: reject invalid IC stack positions #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonycoder-hub wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: reject invalid IC stack positions #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions ecmascript/ic/ic_runtime.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
*/

#include "ecmascript/ic/ic_runtime.h"

#include <charconv>

#include "ecmascript/ic/ic_handler.h"
#include "ecmascript/interpreter/interpreter.h"
#include "ecmascript/interpreter/slow_runtime_stub.h"
Expand Down Expand Up @@ -574,9 +577,16 @@ void ICRuntime::TraceIC([[maybe_unused]] JSThread *thread,
JsFrameInfo jsFrameInfo = jsStackInfo.front();
size_t pos = jsFrameInfo.pos.find(':', 0);
if (pos != CString::npos) {
int lineNumber = std::stoi(jsFrameInfo.pos.substr(0, pos));
int columnNumber = std::stoi(jsFrameInfo.pos.substr(pos + 1));
if (!jsFrameInfo.fileName.empty()) {
auto parsePosition = [](const std::string &value, int &result) {
const char *begin = value.data();
const char *end = begin + value.size();
auto parsed = std::from_chars(begin, end, result);
return parsed.ec == std::errc{} && parsed.ptr == end;
};
int lineNumber = 0;
int columnNumber = 0;
if (parsePosition(jsFrameInfo.pos.substr(0, pos), lineNumber) &&
parsePosition(jsFrameInfo.pos.substr(pos + 1), columnNumber) && !jsFrameInfo.fileName.empty()) {
SourceMap::GetInstance().TranslateUrlPositionBySourceMap(
jsFrameInfo.fileName, lineNumber, columnNumber, jsFrameInfo.packageName);
}
Expand Down