maple: parse preg numbers with from_chars instead of stoi - #1
Open
tonycoder-hub wants to merge 1 commit into
Open
maple: parse preg numbers with from_chars instead of stoi#1tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
Formal names that start with a digit were passed to std::stoi. Empty front() is UB; overflow (2147483648) throws. Parse via from_chars and treat failure as a regular var formal. Signed-off-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Formal names that start with a digit were passed to
std::stoi. Emptyfront()is UB; overflow (2147483648) throws.Parse via
std::from_charsand treat failure as a regular var formal.Test plan
"1"still becomes a preg.g++ -std=c++17 -fsanitize=address,undefined -Iecmascript/compiler/codegen/maple/maple_ir/include ecmascript/compiler/codegen/maple/maple_ir/src/parse_preg_no_host_test.cpp && ./a.outSigned-off-by: Tony Coder 407243179@qq.com