fix: leftover contact-id atoi/stoi - #1
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
DataShare whereArgs and ValuesBucket string contact ids were parsed with atoi/stoi. Overflow is undefined (atoi) or can throw (stoi); junk and partial tokens become 0, so split/merge can hit the wrong raw contact. Parse via std::from_chars (ParseContactIdInt). Valid integers keep the same result; reject empty/overflow/partial/non-digits. Signed-off-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetContactByValueparses untrusted ValuesBucket string contact ids withstd::stoi, andSplit/ReContactMergeparse DataSharewhereArgswithatoi. Overflow is undefined behavior inatoiand can throw instoi; junk and partial tokens become0, so split/merge can hit the wrong raw contact.Parse via
std::from_chars(ParseContactIdInt). Valid integers keep the same result (including0/-1andINT_MAX/INT_MIN); reject overflow/partial/non-digits, log withHILOG_ERROR, and fail the operation instead of using0.Test plan
/workspace/leftover-hosttest/parse_contact_id_int_host_test— valid42/0/01/INT_MAX/INT_MIN/-1parse; overflow (2147483648,9999999999999999999), empty, mixed (1abc), whitespace,+1, and0x10rejected with no sanitizer reports. Predicate helper rejects junk ids.Signed-off-by: Tony Coder 407243179@qq.com