Skip to content

Explicitly say that md5 hex is not usedforsecurity #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suricactus merged 1 commit into from
Apr 29, 2026
Merged

Explicitly say that md5 hex is not usedforsecurity #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions libqfieldsync/utils/file_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,7 @@ def import_file_checksum(path: str) -> Optional[str]:
if os.path.exists(file_path):
with open(file_path, "rb") as f:
file_data = f.read()
# TODO @suricactus: Python 3.9, pass `usedforsecurity=False`
# https://app.clickup.com/t/2192114/QF-6481
md5sum = hashlib.md5(file_data).hexdigest() # noqa: S324
md5sum = hashlib.md5(file_data, usedforsecurity=False).hexdigest()

return md5sum

Expand Down
Loading