Conversation
This reverts commit 614dbe0.
WalkthroughThe Docker base image in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #617 by switching the GoReleaser-built Docker image back to a minimal scratch base, effectively undoing the previous change that introduced a base image with CA certificates.
Changes:
- Change the release Docker image base from
gcr.io/distroless/static:nonroottoscratch. - Keep the image contents minimal (copy
fgabinary, set entrypoint).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.goreleaser.Dockerfile:
- Line 1: The Dockerfile currently uses "FROM scratch" which removes system CA
certificates and user metadata causing TLS failures (x509 unknown authority) and
the container to run as root; fix by either restoring the distroless nonroot
base used before or copy only the CA bundle and a minimal passwd entry from the
build stage into the final image and set a non-root UID; specifically, in the
Dockerfile adjust the final stage that currently uses FROM scratch to (a) use
the distroless nonroot base image OR (b) COPY /etc/ssl/certs/ca-certificates.crt
(or the system cert bundle) and a minimal /etc/passwd entry from the builder
stage into the final image and add a USER directive so the fga binary runs as a
non-root user.
Reverts #617
Summary by CodeRabbit