OEL-2127: Add visually-hidden element when there is no label for close button in offcanvas#684
Open
vengador wants to merge 3 commits into
Open
OEL-2127: Add visually-hidden element when there is no label for close button in offcanvas#684vengador wants to merge 3 commits into
vengador wants to merge 3 commits into
Conversation
…add a visually-hidden element inside button.
… there is no aria label in close button.
|
🚀 Deployed on https://preview-684--oelibrary.netlify.app |
AaronGilMartinez
requested changes
Jul 16, 2025
| {% set _with_backdrop = with_backdrop ?? true %} | ||
| {% set _with_close = with_close ?? true %} | ||
| {% set _close_aria_label = close_aria_label|default('') %} | ||
| {% set _close_content = '' %} |
Collaborator
There was a problem hiding this comment.
Just a comment about code structure, we can put all parameters that can be set at the top and then variables used by the template.
Another option is to add the parameter, but then the pattern should add it too.
So I'd set by default this after line 77 or so:
{% set _close_content %}
<span class="label visually-hidden">Close</span>
{% endset %}
Comment on lines
+103
to
+105
| {% if _close_aria_label %} | ||
| {% set _close_attributes = _close_attributes.setAttribute('aria-label', _close_aria_label) %} | ||
| {% else %} |
Collaborator
There was a problem hiding this comment.
And here we avoid the else:
Suggested change
| {% if _close_aria_label %} | |
| {% set _close_attributes = _close_attributes.setAttribute('aria-label', _close_aria_label) %} | |
| {% else %} | |
| {% if _close_aria_label %} | |
| {% set _close_attributes = _close_attributes.setAttribute('aria-label', _close_aria_label) %} | |
| {% set _close_content = '' %} | |
| {% endif %} |
| {% set _close_attributes = _close_attributes.setAttribute('aria-label', _close_aria_label) %} | ||
| {% else %} | ||
| {% set _close_content %} | ||
| <span class="label visually-hidden">{{ "Close" }}</span> |
Collaborator
There was a problem hiding this comment.
I wonder if we can add the translation filter here and if we should, this texts may not get translated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.