Repository navigation
fix(sql-optim-env): match -ly and doubled-consonant keyword endings - #1612
Merged
burtenshaw merged 2 commits intoNov 13, 2026
Merged
Conversation
Matching issue keywords as whole words (openenv#1006) stopped `explicitly`, `implicitly`, `full scanning` and `zone mapping` from matching the `explicit`, `implicit`, `full scan` and `zone map` keywords, which the earlier substring matcher accepted. Allow a `-ly` ending, and let a final consonant double before -ing/-ed. Every form this re-allows was also matched by the substring matcher, and the fragments the whole-word change rejected (`star` in `started`, `cast` in `forecast`, `join` in `joint`) stay rejected.
burtenshaw
reviewed
Nov 13, 2026
burtenshaw
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this does what the summary says. A -ly ending and a doubled final consonant before -ing/-ed now match, and the false positives #1006 removed (star in started, join in joint, cast in forecast) are still rejected.
I checked the new endings for every task keyword against an English word list. The only new matches with a different meaning are constantly, starred and starring. All three matched before #1006 too, and they are unlikely in a review summary, so this is fine.
CI is green, including both test-sql-optim-env jobs. I'll update the branch and merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1006, from the review there. Matching issue keywords as whole words stopped "explicitly", "implicitly", "full scanning" and "zone mapping" from matching
explicit,implicit,full scanandzone map. This allows a-lyending and a doubled final consonant before -ing/-ed.Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles (grader-only change; reward stays inside the environment).claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issuesRFC Status
Test Plan
TestIssueDetectionMatching(explicitly, implicitly, full scanning, zone mapping, zone mapped); all 5 fail on main.star/started,cast/forecast,join/joint,cte/selected andcorrelated/uncorrelated stay rejected.bash .claude/hooks/lint.shandpython scripts/sync_env_docs.py --checkclean.constantlymatchesconstantagain, as it did before feat(sql-optim-env): add execution-grounded DuckDB SQL query optimization environment #1006.Claude Code Review
N/A
Note
Low Risk
Grader-only heuristic tweak with targeted tests; no execution, auth, or data-path changes.
Overview
Issue-detection keyword matching in the SQL optim grader now treats
-lyadverbs and doubled final consonants before-ing/-edas valid inflections of ground-truth keywords, restoring credit when summaries use forms likeexplicitly,scanning, orzone mappedwhile keeping whole-word boundaries._kw_patternaddslyto the allowed suffix list and, for keywords ending in a consonant, an extra pattern forconsonant + (ing|ed)(e.g.scan→scanning,map→mapped). Tests add five parameterized cases for those phrases.Reviewed by Cursor Bugbot for commit f3ed013. Bugbot is set up for automated code reviews on this repo. Configure here.