Repository navigation
Use 1 m transformer lines in clustering (Fixes #893) - #894
Merged
Merged
Conversation
Contributor
|
Should I review this? |
Contributor
Author
Yes, please. |
ClaraBuettner
self-requested a review
November 2, 2026 09:06
ClaraBuettner
approved these changes
Nov 2, 2026
ClaraBuettner
left a comment
ClaraBuettner
left a comment
Contributor
There was a problem hiding this comment.
Some github tests are failing, but this is not realted to this change. I openend a new issue for this.
This PR can be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transformers are converted to lines of 1 m instead of 1 km before clustering. With kmedoids-dijkstra the two ends then practically never fall into different clusters, so transformers are no longer merged into inter-cluster lines (wrong capital_cost, s_nom_min and x).
How to verify: run the spatial clustering and check capital_cost / length and x of the clustered lines. In our case, line 77581–77587 goes from 435 to 32 €/MW/km/a and from x = 0.0068 to 19 Ω.