build: align release workflow with sample-plugin standard - #297
Merged
Conversation
Attach release assets via a draft `gh release create` instead of python-semantic-release/publish-action, which fails with HTTP 422 once immutable releases freeze a published release's assets. Set vcs_release: "false" so semantic-release builds and tags but leaves GitHub Release creation to us, guaranteeing dists attach before publish. Also bump python-semantic-release to v10.6.2. Mirrors openedx/sample-plugin#57. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
farhan
marked this pull request as ready for review
September 1, 2026 06:40
AhtishamShahid
approved these changes
Sep 1, 2026
Contributor
|
Since this repo is already uv-native ( Avoids pip entirely (in line with the org's uv migration) and is ~2.5-3x faster per run in our testing — PSR's Docker image rebuilds from scratch every run (~40s overhead) vs |
irfanuddinahmad
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Updates the asset-upload step in
.github/workflows/release.ymlto match the sample-plugin release standard, as established in openedx/sample-plugin#57.Why
The openedx org now has GitHub immutable releases enabled, which freezes a release's assets the moment it is published. Our flow (like sample-plugin's before #57) published the release first and then attached the distributions in a separate
python-semantic-release/publish-actionstep — which GitHub now rejects with HTTP 422 (Cannot upload assets to an immutable release).In sample-plugin this silently produced asset-less releases from v3.6.1 onward, and started hard-failing the release job once python-semantic-release v10.6.0+ stopped swallowing the upload error. This repo runs the same flow and would hit the identical failure.
What sample-plugin#57 did (and this PR mirrors)
vcs_release: "false"on thepython-semantic-releasestep — it still commits, tags, pushes and builds, but no longer creates the GitHub Release itself.publish-actionis replaced by agh release createstep that creates the release as a draft, uploads thedist/*assets, and only then publishes it — the sequence immutable releases require. PSR's generated notes are reused via therelease_notesoutput so the release body is unchanged.python-semantic-releasev10.5.3 → v10.6.2.Scope / what is intentionally left unchanged
setup-node,npm ci && npm run build) are kept as-is — xblocks-core builds frontend assets before releasing.user: __token__+PYPI_UPLOAD_TOKEN); this PR does not switch it to OIDC.upload-artifact/download-artifactpins are already correct and untouched.Notes
Draft PR — the release workflow only runs on merge to
main, so end-to-end behaviour can't be exercised on the branch (same caveat as #57, which validated itself by releasing on merge).🤖 Generated with Claude Code