feat: gotenberg support for PDF block - #291
Conversation
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @Kelketek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5005fe8 to
098edae
Compare
Kelketek
changed the title
c0247f0 to
8ec0747
Compare
8ec0747 to
b25204b
Compare
| from openedx_content import api as content_api | ||
|
|
||
| if not source_url.startswith("/"): | ||
| response = requests.get(source_url, timeout=(10, 120)) |
There was a problem hiding this comment.
Shouldn't we check what URL the user sends (like scheme allowlist, the host or resolved IP and redirects)? Otherwise it could result in the same class of bug that this commit fixes in the edx-platform: openedx/openedx-platform@00b7c3ce41
| Checks if the current user has authoring permissions. | ||
| """ | ||
| user_service = self.runtime.service(self, "user") | ||
| permissions_service = self.runtime.service(self, "studio_user_permissions") |
There was a problem hiding this comment.
This doesn't work in content library v2. Only django admins get user_is_staff as true so any other library authors will get blocked.
| if not (conversion_url := get_conversion_url()): # pragma: no cover | ||
| return None | ||
|
|
||
| pdf_response = requests.post(conversion_url, files={"file": (source_filename, data)}, timeout=(2, 120)) |
There was a problem hiding this comment.
Nit: Could be useful to put this in a try/except block and handle the error incase the Gotenberg container becomes unreachable for some reason.
4 participants
Description
This Pull Request adds support for conversion of documents to PDF via the Gotenberg service if it is available.
Supporting information
Testing instructions
tutor mounts add /path/to/xblocks-coretutor images build openedx-dev