chore: update Makefile for local translation configurations

[alenkadev]

Title: Switch to using local translations (AU-2765)

Description:
Declares ATLAS_EXTRA_SOURCES, ATLAS_EXTRA_INTL_IMPORTS, and ATLAS_OPTIONS as overridable Makefile variables (?=, default empty).
Appends $(ATLAS_EXTRA_SOURCES) to the atlas pull command in pull_translations, so extra translations/: entries can be pulled alongside the existing ones.
Appends (ATLAS_EXTRA_INTL_IMPORTS) to the $(intl_imports) call, so any extra sources pulled above are also registered/imported

jira-link : https://2u-internal.atlassian.net/browse/LP-330

[jristau1984]

@alenkadev it looks like you have a lint failure. can you please correct that?

[alenkadev]

@alenkadev it looks like you have a lint failure. can you please correct that?

resolved

[jristau1984]

@arbrandes any chance you can help us understand the timeline for this review? We have an internal ticket tied to this, and I would like to set expectations to the stakeholders watching that ticket. Thanks!

[brian-smith-tcril]

Is this intended for the frontend-base "app" version of this or the frontend-build/frontend-platform "plugin" version of this?

The PR is pointing to main which is now the frontend-base version, and these changes don't make sense there at all. I'm not 100% sure about them on the build/platform side of things either but it would be very helpful context for review.

[arbrandes]

This doesn't make sense on the main branch.

ATLAS_EXTRA_INTL_IMPORTS has no reader. frontend-base's translations:pull takes external input only from --atlas-options= on argv, so exporting the variable into the environment does nothing.

ATLAS_EXTRA_SOURCES is now the site's concern. A deployment adds translation sources by listing packages under atlasTranslations.dependencies in its site package.json, as frontend-template-site does, where this app is already included. translations:pull resolves that list through node_modules, reads each package's own atlasTranslations.path, and computes the destination itself.

Both variables were dropped for these reasons during the frontend-base i18n conversion, in 59a80e6 on frontend-app-learner-dashboard, for example.

So yes, maybe you meant to target the 2.x branch?

[alenkadev]

closing this PR as the PR for these changes needs to be raised against 2.x branch