Skip to content

feat: new permissions added to the roles and permissions matrix - #215

Merged
jacobo-dominguez-wgu merged 4 commits into
openedx:masterfrom
WGU-Open-edX:permissions-matrix
Aug 25, 2026
Merged

feat: new permissions added to the roles and permissions matrix#215
jacobo-dominguez-wgu merged 4 commits into
openedx:masterfrom
WGU-Open-edX:permissions-matrix

Conversation

@jesusbalderramawgu

Copy link
Copy Markdown
Contributor

Description

New permissions added to the roles and permissions matrix

this PR closes these four issues :
openedx/openedx-authz#393
openedx/openedx-authz#396
openedx/openedx-authz#399
openedx/openedx-authz#402

Screenshots with the new permissions

Screenshot 2026-08-20 at 3 06 12 p m Screenshot 2026-08-20 at 3 08 14 p m

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 20, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @jesusbalderramawgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@dcoa

dcoa commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@jesusbalderramawgu thank you for this, please make sure the linter passes

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.65%. Comparing base (c08e45d) to head (a382b16).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   97.64%   97.65%           
=======================================
  Files          68       68           
  Lines        1702     1665   -37     
  Branches      447      408   -39     
=======================================
- Hits         1662     1626   -36     
+ Misses         40       39    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jesusbalderramawgu

jesusbalderramawgu commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@jesusbalderramawgu thank you for this, please make sure the linter passes

you are right, fixed. Thanks @dcoa!

@dcoa dcoa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks good. I suggested some improvements in description

{
key: CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_ADVANCED_SETTINGS,
resource: 'course_advanced_certificates',
description: 'Access and view the Advanced Settings page in Studio. This covers a wide range of technical course configurations, including proctoring, timed exams, LTI tools, enrollment limits, and custom display options.',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: 'Access and view the Advanced Settings page in Studio. This covers a wide range of technical course configurations, including proctoring, timed exams, LTI tools, enrollment limits, and custom display options.',
description: 'Access the Advanced Settings page in Studio. This covers a wide range of technical course configurations, including proctoring, timed exams, LTI tools, enrollment limits, and custom display options.',

Then in edit description we can use a simplified version to avoid being repetitive

description: 'Edit technical course configurations in the Advanced Settings page in Studio.',

What do you think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I have updated the texts. Thank you!

{
key: CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_CERTIFICATES,
resource: 'course_advanced_certificates',
description: 'See the course certificate settings, including certificate design and eligibility criteria.',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the same reasoning:

Suggested change
description: 'See the course certificate settings, including certificate design and eligibility criteria.',
description: 'See the course certificate settings.',

@dcoa dcoa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small change left

CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_SCHEDULE_AND_DETAILS,
CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_ADVANCED_SETTINGS,
CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_CERTIFICATES,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this extra space, please?

@jacobo-dominguez-wgu
jacobo-dominguez-wgu merged commit 36cc825 into openedx:master Aug 25, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment