fix: added logout user before sso pipeline starts#402
Merged
feanil merged 5 commits intoopenedx:masterfrom Sep 30, 2025
Merged
Conversation
robrap
reviewed
Sep 25, 2025
robrap
approved these changes
Sep 26, 2025
feanil
approved these changes
Sep 29, 2025
Contributor
|
@Akanshu-2u changes look good, can you bump the version of the library so that we can do a release once we merge this? |
Contributor
Author
Addressed. Added version bump of the library. Thank you. |
feanil
approved these changes
Sep 30, 2025
Contributor
|
Thanks @feanil. |
Contributor
|
@feanil: We'll see if we can get this fully tested and rolled out (on by default) for Ulmo on Oct 9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Users logging in through OAuth SSO could retain session data from previous logins, creating potential security risks and confusion when switching between accounts.
Solution:
Added
logout(request)call inEdXOAuth2.start()method to clear existing sessions before OAuth authentication begins.JIRA:
BOMS-3
Note: