Repository navigation
fix: omit language from non-public form 403 - #264
Merged
Merged
Conversation
GET /api/public/forms/:id no longer returns the creator-chosen language on 403 for a non-public form. The respondent UI falls back to the browser locale or en-US. Fixes #259 Co-authored-by: Rafal Korszun <rkorszun@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259
Summary
GET /api/public/forms/:idno longer returns the creator-chosenlanguageon 403 for a non-public form. That field was a small metadata leak after #250.The respondent UI still localizes the closed/error message: it uses
languagewhen the API sends it (public-but-inactive 403), otherwise it maps the browser locale (pl-PL→pl,en-GB→en-US) and falls back toen-US.Root cause
FormsService.findPublicFormthrewForbiddenException({ message, language })for!form.isPublic, so Nest serializedlanguageon an unauthenticated 403.Fix
ForbiddenException('This form is not public')— nolanguage.language(the form was already public).detectBrowserLanguage()for 403/404/load errors when the body has no language.Tests
language; inactive public 403 still has it.navigator.language = pl-PLshows PolishformClosed.language.Local results
pnpm --filter server testpnpm --filter client testpnpm --filter client exec tsc --noEmitDo not merge. Draft until CI is green.