Fix request deletion based on PROVISION requestable flag - #90
Merged
ivan-risueno merged 10 commits intoSep 15, 2026
Merged
Conversation
ivan-risueno
requested review from
hrcornejo,
jordivx,
sergio-esperalta-bi and
sergio-soria-bi
September 8, 2026 15:05
This reverts commit b4aa345.
sergio-soria-bi
approved these changes
Sep 14, 2026
jordivx
reviewed
Sep 14, 2026
|
|
||
| var accessToken = authenticationProvider.getAccessToken(); | ||
| var projectComponent = componentCatalogService.getProjectComponentById(accessToken, projectKey, componentId); | ||
| var catalogItem = fetchCatalogItem(accessToken, getCatalogItemId(projectComponent), projectKey); |
Contributor
There was a problem hiding this comment.
Provisioning and deletion should follow different business logic. Instead of checking if is requestable, I'd use the "canBeDeleted" property from the components (seems the endpoint used doesn't provide it but there are other endpoints that do) to have a single source of truth whereas can be deleted or not.
ivan-risueno
force-pushed
the
bugfix/forbid-deletion-to-non-team-nor-manager-users
branch
from
September 14, 2026 10:40
79889de to
9ff1da1
Compare
|
jordivx
approved these changes
Sep 15, 2026
ivan-risueno
deleted the
bugfix/forbid-deletion-to-non-team-nor-manager-users
branch
September 15, 2026 07:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.