Fix catalogItemId resolution when validating whitelisted roles - #87
Open
ivan-risueno wants to merge 2 commits into
Open
Fix catalogItemId resolution when validating whitelisted roles#87ivan-risueno wants to merge 2 commits into
ivan-risueno wants to merge 2 commits into
Conversation
ivan-risueno
requested review from
hrcornejo,
jordivx,
sergio-esperalta-bi and
sergio-soria-bi
September 8, 2026 14:16
sergio-soria-bi
requested changes
Sep 14, 2026
| @Service | ||
| @Slf4j | ||
| @AllArgsConstructor | ||
| public class CatalogItemSlugResolver { |
Contributor
There was a problem hiding this comment.
At component catalog, we have
I think it makes sense to unify and use exactly same class (so, if some day we generate a shared library or so, we reduce refactor collisions)
Contributor
Author
There was a problem hiding this comment.
Fair enough, working into it
EDIT: We will work on an isolated slug conversion in the future, agreed with the team.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.