Set raw component url value when updating a component - #84
Merged
ivan-risueno merged 2 commits intoSep 4, 2026
Merged
Conversation
ivan-risueno
requested review from
hrcornejo,
jordivx,
sergio-esperalta-bi and
sergio-soria-bi
September 4, 2026 07:40
sergio-soria-bi
requested changes
Sep 4, 2026
|
|
||
| assertThat(result.getStatus()).isEqualTo(Status.CREATED); | ||
| assertThat(result.getComponentUrl()).isEqualTo("oldUrl"); // unchanged | ||
| assertThat(result.getComponentUrl()).isEqualTo(null); |
Contributor
There was a problem hiding this comment.
Ideally, we should never set null value to componentUrl, that's a bug we fixed in the recent past
Contributor
There was a problem hiding this comment.
After a talk, it makes more sense to me to set emtpy string, instead of null, for the test.
Contributor
Author
There was a problem hiding this comment.
Seems fine for me 👍
sergio-soria-bi
approved these changes
Sep 4, 2026
|
ivan-risueno
deleted the
bugfix/component_url-not-getting-stored-anymore
branch
September 4, 2026 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.