feat(integrations): report google authorization status - #59
Merged
Conversation
Add POST /integrations/google/status/, which answers whether the caller has granted the Google calendar and tasks capabilities. Not having granted them is a normal answer rather than a failure, so the check returns 200 either way and clients branch on the body. When capabilities are missing the response relays Verisafe's authorization instruction verbatim. The client makes that call itself, supplying its own platform, redirect_uri, and bearer token: starting a consent flow needs the user's token, which this service deliberately does not hold. The url handed back is Verisafe's authorize endpoint, not the Google consent screen. Check grants rather than requesting a token, so no Google credential is minted to answer a yes/no question. The token call happens only when something is missing, where it is expected to be refused, and the refusal is what carries the authoritative url and method. Report a rejected service token as 502 rather than 403. A 403 would tell the client that the user must re-authorize, sending them through a consent flow to fix a misconfiguration that was never theirs. Queue a pull when everything is granted, so a user who has just finished authorizing sees their tasks without waiting for the next scheduled sync.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add POST /integrations/google/status/, which answers whether the caller has granted the Google calendar and tasks capabilities. Not having granted them is a normal answer rather than a failure, so the check returns 200 either way and clients branch on the body.
When capabilities are missing the response relays Verisafe's authorization instruction verbatim. The client makes that call itself, supplying its own platform, redirect_uri, and bearer token: starting a consent flow needs the user's token, which this service deliberately does not hold. The url handed back is Verisafe's authorize endpoint, not the Google consent screen.
Check grants rather than requesting a token, so no Google credential is minted to answer a yes/no question. The token call happens only when something is missing, where it is expected to be refused, and the refusal is what carries the authoritative url and method.
Report a rejected service token as 502 rather than 403. A 403 would tell the client that the user must re-authorize, sending them through a consent flow to fix a misconfiguration that was never theirs.
Queue a pull when everything is granted, so a user who has just finished authorizing sees their tasks without waiting for the next scheduled sync.