Support for Router Interface Meta Data#2209
Open
komal-marvell wants to merge 1 commit intoopencomputeproject:masterfrom
Open
Support for Router Interface Meta Data#2209komal-marvell wants to merge 1 commit intoopencomputeproject:masterfrom
komal-marvell wants to merge 1 commit intoopencomputeproject:masterfrom
Conversation
itaibaz
reviewed
Sep 17, 2025
doc/SAI-Proposal-RIF-Metadata.md
Outdated
| typedef union _sai_acl_capability_extended_value_t | ||
| { | ||
| /** @validonly type == SAI_ACL_CAPABILITY_EXTENDED_TYPE_ROUTER_INTERFACE_META_DATA */ | ||
| sai_u32_range_t router_interface_meta_data_range; |
Collaborator
There was a problem hiding this comment.
what happens if we want to add additional attributes in the future and need a bigger data type. This becomes again non binary compatible
Collaborator
There was a problem hiding this comment.
so this is a new complex mechanism, but seems not extendable
and in the end, do you really need different metadata range per stage ?
or can we just add new attribute like SAI_SWITCH_ATTR_ACL_USER_META_DATA_RANGE
komal-marvell
force-pushed
the
rif_meta
branch
2 times, most recently
from
f1236f4 to
9e7d9da
Compare
Signed-off-by: Komal Shah <kshah2@marvell.com>
komal-marvell
force-pushed
the
rif_meta
branch
from
9e7d9da to
6c9a192
Compare
Collaborator
|
@komal-marvell - could you please resolve branch conflicts and update the PR with the usecase as discussed in the last meeting? |
Collaborator
|
@komal-marvell - gentle reminder on this |
Collaborator
|
@rck-innovium, @rajkumar38, @komal-marvell - reminder on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata can be assigned on Router Interface and subsequently matched in ACL entries, providing increased flexibility for policy management.