Add DF Mode, nexthopgroup id and splithorizon list assignment#1965
Draft
naveen-gamini wants to merge 1 commit intoopencomputeproject:masterfrom
Draft
Add DF Mode, nexthopgroup id and splithorizon list assignment#1965naveen-gamini wants to merge 1 commit intoopencomputeproject:masterfrom
naveen-gamini wants to merge 1 commit intoopencomputeproject:masterfrom
Conversation
Collaborator
|
before making this PR for review please fix all the errors and sign commits |
| { | ||
| SAI_VLAN_DF_MODE_IGNORE, | ||
|
|
||
| SAI_VLAN_DF_MODE_BLOCKED, |
Contributor
There was a problem hiding this comment.
can you plesae add more details on what exactly these modes are..
| /** | ||
| * @brief Split Horizon List ID | ||
| * | ||
| * Valid only for Ethernet Segment Ports - EVPN Multihoming feature |
Contributor
There was a problem hiding this comment.
what is the PORT attribute to define whether the port is Ethernet segment PORT or not...?
| * @default SAI_NULL_OBJECT_ID | ||
| * @objects SAI_OBJECT_TYPE_NEXT_HOP_GROUP | ||
| */ | ||
| SAI_FDB_ENTRY_ATTR_NEXT_HOP_GROUP_ID, |
Contributor
There was a problem hiding this comment.
Does it need any changes in nexthopgroup types..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a Draft PR for HLD review of EVPN Multihoming feature