Skip to content

Make solid optional #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickhummel merged 3 commits into from
May 20, 2026
Merged

Make solid optional #90

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e54bcce
Merge pull request #11 from opencomputeproject/main
rob-tetrel Mar 27, 2026
9c3e676
Merge branch 'opencomputeproject:main' into main
rob-tetrel May 20, 2026
25179b8
OCP SOLID is optional prior to 2026-10-01, make the code support buil…
rob-tetrel May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions shortform_report-main/OcpReportLib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,9 @@ def add_audit(
self.report["audit"]["completion_date"] = f"{date}".strip()
self.report["audit"]["report_version"] = f"{report_ver}".strip()
self.report["audit"]["scope_number"] = scope_number
self.report["audit"]["solid_ver"] = solid_ver
if solid_ver:
# optional before 2026-10-01
self.report["audit"]["solid_ver"] = solid_ver
self.report["audit"]["cvss_version"] = f"{cvss_ver}".strip()
self.report["audit"]["issues"] = []

Expand Down Expand Up @@ -386,7 +388,8 @@ def _convert_to_corim_structure(self) -> Dict[str, Any]:
if corim_issues:
sfr_map[5] = corim_issues # issues

if self.report["audit"]["solid_ver"]:
if "solid_ver" in self.report["audit"] and self.report["audit"]["solid_ver"]:
# optional before 2026-10-01
sfr_map[6] = self.report["audit"]["solid_ver"] # solid-version

return sfr_map
Expand Down
Loading