Conversation
If users set a value for `SYMBOLSUFFIX`, they need to use BLAS and LAPACK libraries that export symbols with that suffix. However, the tests for these libraries are done *before* the suffix replacement flags have been added. So, BLAS and LAPACK libraries that export symbols with the *expected* suffix are not recognized. Move the check for the LAPACK and BLAS libraries to where the suffix handling is already done. Fixes opencollab#477.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request purpose
If users set a value for
SYMBOLSUFFIX, they need to use BLAS and LAPACK libraries that export symbols with that suffix.However, the tests for these libraries are done before the suffix replacement flags have been added. So, BLAS and LAPACK libraries that export symbols with the expected suffix are not recognized.
Detailed changes proposed in this pull request
Move the check for the LAPACK and BLAS libraries to where the suffix handling is already done.
Fixes #477.