Conversation
Some distributions (e.g., Debian/Ubuntu or MSYS2) split the parpack library into a separate package. That leads to issues if their arpack package is installed but their parpack package is not. Auto-generated CMake target files check whether the respective files actually exist on disc. Because both the arpack import target and the parpack import target are included in the same auto-generated CMake target file of arpack-ng (if it was configured to be built parpack), that leads to a fatal error when attempting to import the arpack CMake target in downstream projects while the parpack files are not installed. Support using the CMake config files in the case where distributions split parpack into a separate package, and that package is not installed. That is done by auto-generating a separate CMake target file for parpack, and checking whether it exists before including it in the CMake config file. Distributors can then move the CMake target file for parpack to their separate package.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request purpose
Some distributions (e.g., Debian/Ubuntu or MSYS2) split the parpack library into a separate package.
That leads to issues if their arpack package is installed but their parpack package is not.
Auto-generated CMake target files check whether the respective files actually exist on disc. Because both the arpack import target and the parpack import target are included in the same auto-generated CMake target file of arpack-ng (if it was configured to be built parpack), that leads to a fatal error when attempting to import the arpack CMake target in downstream projects while the parpack files are not installed.
Detailed changes proposed in this pull request
Support using the CMake config files in the case where distributions split parpack into a separate package, and that package is not installed.
That is done by auto-generating a separate CMake target file for parpack, and checking whether it exists before including it in the CMake config file. Distributors can then move the CMake target file for parpack to their separate package.