fix(deps): update dependency focus-trap to v8#1935
Closed
renovate[bot] wants to merge 1 commit intomainfrom
Closed
fix(deps): update dependency focus-trap to v8#1935renovate[bot] wants to merge 1 commit intomainfrom
renovate[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Not doing this for now since |
Contributor
Author
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^7.8.0→^8.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
focus-trap/focus-trap (focus-trap)
v8.0.0Compare Source
Major Changes
b6ea4b5: Breaking: Fixed a long-standing bug whereonPostActivate()would be called before the initial focus node was focused and the trap was fully activated. (#1747)setTimeout(0)) but wasn't delaying callingonPostActivate()until after that delay.isolateSubtrees='aria-hidden'option, the currently-focused node's container (a non-subtree being "disabled") would get hidden before the delay was up, resulting in Chrome preventing the effect ofaria-hiddenon that subtree with a warning in the console due to the container being hidden still containing focus (e.g. the "activate trap" button).onPostActivate()await the initial focus delay (if there is one, which is default behavior; remove it withdelayInitialFocus=false) before being applied/called.await waitFor(() => expect(initialFocusNode).toBeFocused()).onPostActivate()handler (prior to this change, that node would not be focused yet; after this change, it will be focused).Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.