fix: download via batch actions when single file is selected in searc…#1934
Merged
AlexAndBear merged 1 commit intomainfrom Feb 5, 2026
Merged
fix: download via batch actions when single file is selected in searc…#1934AlexAndBear merged 1 commit intomainfrom
AlexAndBear merged 1 commit intomainfrom
Conversation
JammingBen
reviewed
Feb 5, 2026
Contributor
JammingBen
left a comment
There was a problem hiding this comment.
Why change the signature of the downloadFile method? Technically this would now be a breaking change for web-pkg.
Contributor
Author
|
If we kept the old signature, the method would look like this: This signature mixes required and optional params and relies on null defaults, which is a bit messy and easy to misuse. |
…h and shared with me view
93c1926 to
85cfa70
Compare
JammingBen
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…h and shared with me view
Description
Related Issue
How Has This Been Tested?
Types of changes