Skip to content

fix: download via batch actions when single file is selected in searc…#1934

Merged
AlexAndBear merged 1 commit intomainfrom
issues/1932
Feb 5, 2026
Merged

fix: download via batch actions when single file is selected in searc…#1934
AlexAndBear merged 1 commit intomainfrom
issues/1932

Conversation

@AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Feb 4, 2026

…h and shared with me view

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the signature of the downloadFile method? Technically this would now be a breaking change for web-pkg.

@AlexAndBear
Copy link
Contributor Author

If we kept the old signature, the method would look like this:

  space: SpaceResource = null,
  file: Resource,
  version: string = null
) => {

This signature mixes required and optional params and relies on null defaults, which is a bit messy and easy to misuse.

@AlexAndBear AlexAndBear merged commit 86a67bd into main Feb 5, 2026
28 checks passed
@AlexAndBear AlexAndBear deleted the issues/1932 branch February 5, 2026 10:59
@openclouders openclouders mentioned this pull request Feb 5, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants