Fix tray app display name branding#946
Conversation
Use OpenClaw Companion as the visible app identity for toasts, installer shortcuts, and approval/permission popup titles. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs maintainer review before merge. Reviewed July 8, 2026, 7:24 PM ET / 23:24 UTC. Summary Reproducibility: yes. at source level: current main lacks installer AppUserModelID wiring and still uses OpenClaw.Tray.WinUI in the unpackaged manifest. I did not run a live Windows repro in this read-only review, but the PR body includes current-head native popup proof. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land the focused branding/AUMID alignment after maintainers accept the Windows shell identity upgrade behavior, keeping AppIdentity as the source of truth and retaining the contract tests. Do we have a high-confidence way to reproduce the issue? Yes at source level: current main lacks installer AppUserModelID wiring and still uses OpenClaw.Tray.WinUI in the unpackaged manifest. I did not run a live Windows repro in this read-only review, but the PR body includes current-head native popup proof. Is this the best way to solve the issue? Yes: centralizing the AUMID through AppIdentity and aligning process registration, installer shortcuts, metadata, manifest identity, and prompt titles is the narrow maintainable fix. The remaining concern is maintainer acceptance of shell identity upgrade behavior, not a concrete code defect. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 02f2421a5e75. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Summary
OpenClaw Companion/OpenClaw Companion (Dev)as the visible app identity for toast sender fallback, unpackaged app metadata, and approval/permission popup titles.OpenClaw.Tray.WinUIfor notifications.OpenClaw ·prefixes to avoid double-branded titles.Validation
./build.ps1— passeddotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore— passed (2703 passed, 31 skipped)dotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore— passed (1592 passed)Real behavior proof
FileDescription: OpenClaw CompanionProductName: OpenClaw CompanionC:\Projects\copilot-worktrees\openclaw-windows-node\bkudiess-symmetrical-carnival\src\OpenClaw.Tray.WinUI\bin\Debug\net10.0-windows10.0.22621.0\win-arm64\OpenClaw.Tray.WinUI.exewinnode --mcp-port 18766 --command system.run --params '{"command":"cmd","args":["/c","echo proof-current-head-unique-946"],"timeoutMs":30000}'OpenClaw.Companion/OpenClaw.Companion.Dev.{#MyAppAumid}.AppIdentity.DisplayName.OpenClaw ·, preventing double-branding.