Remove Notifications from sidebar#943
Conversation
Keep notifications accessible from the title bar bell only and remove the stale footer nav localization entries. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs maintainer review before merge. Reviewed July 8, 2026, 2:27 PM ET / 18:27 UTC. Summary Reproducibility: not applicable. This PR removes a redundant navigation affordance rather than fixing a reproducible bug. Source inspection and the PR body's accessibility output verify the affected UI state. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Keep Notifications reachable through the title-bar bell and command palette while removing the redundant footer row if maintainers accept the simplified navigation. Do we have a high-confidence way to reproduce the issue? Not applicable; this PR removes a redundant navigation affordance rather than fixing a reproducible bug. Source inspection and the PR body's accessibility output verify the affected UI state. Is this the best way to solve the issue? Yes; the patch deletes only the footer/sidebar affordance and stale resources while preserving the bell handler, NotificationsPage route, and command palette entry. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 87634727b65b. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
shanselman
left a comment
There was a problem hiding this comment.
Reviewed with >90% confidence. Tiny deletion-only sidebar cleanup; title-bar Notifications bell remains, CI and UIA proof are green.
Summary
HubWindow.xaml.Validation
git diff --check— passed./build.ps1— passeddotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore— passed: 2703 passed, 31 skippeddotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore— passed: 1586 passedReal behavior proof
Runtime launch from current head succeeded with isolated tray data and opened the Hub window:
Copied current-head Hub UI evidence from computer-use accessibility inspection:
This shows the title-bar Notifications bell is still present while the navigation rail/footer contains no Notifications row; only Diagnostics remains in the footer. The isolated proof instance used
OPENCLAW_TRAY_DATA_DIRso real%APPDATA%\OpenClawTraysettings were not mutated.