Skip to content

Remove Notifications from sidebar#943

Merged
shanselman merged 1 commit into
mainfrom
bkudiess-remove-sidebar-notifications
Jul 8, 2026
Merged

Remove Notifications from sidebar#943
shanselman merged 1 commit into
mainfrom
bkudiess-remove-sidebar-notifications

Conversation

@bkudiess

@bkudiess bkudiess commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the footer/sidebar Notifications navigation item so notifications are exposed only through the title-bar bell.
  • Remove the now-unused sidebar Notifications icon resource from HubWindow.xaml.
  • Remove stale localized resource entries for the deleted navigation label.

Validation

  • git diff --check — passed
  • ./build.ps1 — passed
  • dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore — passed: 2703 passed, 31 skipped
  • dotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore — passed: 1586 passed

Real behavior proof

Runtime launch from current head succeeded with isolated tray data and opened the Hub window:

Branch:        bkudiess-remove-sidebar-notifications
Configuration: Debug
Runtime:       win-arm64
Mode:          Direct unpackaged executable
Data dir:      C:\Users\bakudies\AppData\Local\Temp\OpenClawTray\proof-pr-943-hub
Started OpenClaw Tray (PID: 24108)
Window title:  OpenClaw Companion

Copied current-head Hub UI evidence from computer-use accessibility inspection:

15 AXButton Notifications ID: NotificationsBellButton
22 AXGroup Main navigation ID: NavView
25 AXGroup Main navigation ID: MenuItemsHost
  26 AXStaticText Gateway
  27 AXRow (selected) Connection
  29 AXStaticText This Computer
  30 AXRow (selectable) Voice & Audio
  32 AXRow (selectable) Permissions
  34 AXRow (selectable) Sandbox
  36 AXRow (selectable) Settings
38 AXScrollArea ID: FooterItemsScrollViewer
  39 AXGroup ID: FooterMenuItemsHost
    40 AXRow (selectable) Diagnostics ID: NavDiagnostics

This shows the title-bar Notifications bell is still present while the navigation rail/footer contains no Notifications row; only Diagnostics remains in the footer. The isolated proof instance used OPENCLAW_TRAY_DATA_DIR so real %APPDATA%\OpenClawTray settings were not mutated.

Keep notifications accessible from the title bar bell only and remove the stale footer nav localization entries.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@clawsweeper

clawsweeper Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge. Reviewed July 8, 2026, 2:27 PM ET / 18:27 UTC.

Summary
The branch deletes the Hub footer/sidebar Notifications navigation item, its XAML icon resource, and matching localized sidebar label entries.

Reproducibility: not applicable. This PR removes a redundant navigation affordance rather than fixing a reproducible bug. Source inspection and the PR body's accessibility output verify the affected UI state.

Review metrics: 1 noteworthy metric.

  • Diff size: 0 added, 19 removed across 6 files. The deletion-only scope keeps review focused on retained navigation reachability and localization consistency.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

  • none.

Next step before merge

  • No automated repair is needed; the patch is a small proven UI cleanup awaiting ordinary maintainer merge review.

Security
Cleared: The diff deletes WinUI XAML and resource entries only; it does not touch dependencies, secrets, permissions, install scripts, or code execution paths.

Review details

Best possible solution:

Keep Notifications reachable through the title-bar bell and command palette while removing the redundant footer row if maintainers accept the simplified navigation.

Do we have a high-confidence way to reproduce the issue?

Not applicable; this PR removes a redundant navigation affordance rather than fixing a reproducible bug. Source inspection and the PR body's accessibility output verify the affected UI state.

Is this the best way to solve the issue?

Yes; the patch deletes only the footer/sidebar affordance and stale resources while preserving the bell handler, NotificationsPage route, and command palette entry.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 87634727b65b.

Label changes

Label justifications:

  • P3: This is a low-risk tray UI cleanup with limited blast radius and retained alternate access to Notifications.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🦞 diamond lobster.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (live_output): The PR body includes isolated launch output and computer-use accessibility output showing the Notifications bell still present and the footer Notifications row absent.
  • proof: sufficient: Contributor real behavior proof is sufficient. The PR body includes isolated launch output and computer-use accessibility output showing the Notifications bell still present and the footer Notifications row absent.
Evidence reviewed

What I checked:

Likely related people:

  • shanselman: git blame and git log -S trace the HubWindow Notifications sidebar item, bell route, command route, and NotificationsPage tag mapping to the merged HubWindow work in 4166e0f. (role: introduced behavior; confidence: high; commits: 4166e0fd63f8; files: src/OpenClaw.Tray.WinUI/Windows/HubWindow.xaml, src/OpenClaw.Tray.WinUI/Windows/HubWindow.xaml.cs, src/OpenClaw.Tray.WinUI/Strings/en-us/Resources.resw)
  • karkarl: The merged accessibility pass in 6045c2d touched the HubWindow navigation icon line adjacent to the removed footer item. (role: recent area contributor; confidence: medium; commits: 6045c2d00e1f; files: src/OpenClaw.Tray.WinUI/Windows/HubWindow.xaml)
  • bkudiess: Current-main history shows prior HubWindow.xaml.cs work in 74604ae, so the PR author also has adjacent area context beyond this proposed branch. (role: recent adjacent contributor; confidence: medium; commits: 74604aebafef; files: src/OpenClaw.Tray.WinUI/Windows/HubWindow.xaml.cs)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.
Review history (2 earlier review cycles)
  • reviewed 2026-07-08T05:39:06.374Z sha 3e1050e :: needs maintainer review before merge. :: none
  • reviewed 2026-07-08T18:21:35.868Z sha 3e1050e :: needs maintainer review before merge. :: none

@clawsweeper clawsweeper Bot added rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. labels Jul 8, 2026
@bkudiess

bkudiess commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

@clawsweeper re-review

@clawsweeper

clawsweeper Bot commented Jul 8, 2026

Copy link
Copy Markdown

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

@clawsweeper clawsweeper Bot added proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Jul 8, 2026

@shanselman shanselman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with >90% confidence. Tiny deletion-only sidebar cleanup; title-bar Notifications bell remains, CI and UIA proof are green.

@shanselman shanselman merged commit cc2834c into main Jul 8, 2026
21 checks passed
@shanselman shanselman deleted the bkudiess-remove-sidebar-notifications branch July 8, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P3 Low-risk cleanup, docs, polish, ergonomics, or speculative feature. proof: sufficient Contributor real behavior proof is sufficient. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants