Add OpenClaw red-bot brand mark#942
Conversation
Introduce a shared BrandMark control for the tray UI and replace the old lobster/generic robot marks in title bars, dialogs, and the Agent Events empty state. Remove the dead FluentIconCatalog brand emoji and add source-text contracts for the red-bot mark. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs maintainer review before merge. Reviewed July 8, 2026, 3:33 PM ET / 19:33 UTC. Summary Reproducibility: not applicable. This PR changes visual branding rather than reporting a bug. Source inspection of current main still shows the old placeholders, and the inspected screenshots show the changed Hub surface. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Proceed with ordinary maintainer merge review of the bounded BrandMark cleanup, preserving the existing red-bot asset path, native Windows accent behavior, and source-text contracts. Do we have a high-confidence way to reproduce the issue? Not applicable; this PR changes visual branding rather than reporting a bug. Source inspection of current main still shows the old placeholders, and the inspected screenshots show the changed Hub surface. Is this the best way to solve the issue? Yes; a shared WinUI control backed by the existing packaged red-bot asset is the narrow maintainable solution for replacing repeated emoji brand placeholders. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 87634727b65b. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (4 earlier review cycles)
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review |
shanselman
left a comment
There was a problem hiding this comment.
Reviewed with >90% confidence. BrandMark is decorative/raw for accessibility, hit-test safe, covered by contract tests, and CI is green.
Summary
BrandMarkWinUI control backed by the red-bot app asset.FluentIconCatalog.Brandemoji constant and update source-text contracts.Validation
./build.ps1✅dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restore✅ 2703 passed / 31 skippeddotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore --filter FullyQualifiedName~BrandMarkContractTests✅ 3 passeddotnet build .\src\OpenClaw.Tray.WinUI\OpenClaw.Tray.WinUI.csproj --no-restore -p:RuntimeIdentifier=win-arm64 -v:minimal✅Build and Testworkflow ✅ all required jobs green on the PR.AssistantBridgeServiceTests.StartListenServiceAsync_KillsTimedOutBackendCommandcan fail in the full suite on currentorigin/main; the same failure reproduced on cleanorigin/main, and the single test passed when run alone.Real behavior proof
./run-app-local.ps1 -NoBuild -Isolated -AllowNonMain✅ launched current branch app successfully.%TEMP%\OpenClawTray\bkudiess-turbo-doodle-bkudiess-app-wide-icon-branding-onboarding-1b7989caBrandMarkimmediately beforeOpenClaw Windows Companion; native Windows accent colors remain unchanged in the NavigationView selection and toggles.OpenClaw CompanionHub window was observed withTitleText = OpenClaw Windows Companion, native sidebar icons, and active Connection surface; screenshot view showed the red-bot title-bar mark in the changed surface.Review
MarkSizecoercion, and stronger BrandMark contract tests.