Fix run-app-local build argument forwarding#939
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run-app-local.ps1so its default build path forwardsConfigurationtobuild.ps1by name instead of accidentally binding-Configurationas the positionalProjectargument.-Devforwarding explicit through the existingDevBuildswitch.Validation
dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore --filter "FullyQualifiedName~LocalInstallerBuild_UsesOneIdentitySwitchAndValidatesPayloadMarker"— passed: 1..\run-app-local.ps1 -DryRun -Configuration Debug— passed after stopping the previously launched tray process that locked the output assembly..\build.ps1— passed.dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restore— passed: 2703 passed / 31 skipped.dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore— passed: 1584 passed.Real behavior proof
run-app-local.ps1default build path now invokesbuild.ps1successfully without mis-binding-Configuration.mainsucceeded after the fix.