fix(setup): extend timeouts for slow wizard steps#930
Conversation
Co-authored-by: Ranjesh Jaganathan <ranjeshj@microsoft.com>
|
Codex review: needs real behavior proof before merge. Reviewed July 6, 2026, 12:09 PM ET / 16:09 UTC. Summary Reproducibility: yes. at source level, but not live: current main only classifies auth text for extended timeouts while the PR-linked bug needs Teams/plugin selected-option context. I did not run a real Teams setup reproduction in this read-only review. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Maintainer decision needed
Security Review detailsBest possible solution: Land this focused timeout fix after normal checks and either live slow Teams/plugin proof or an explicit maintainer proof override confirms the source/test evidence is enough. Do we have a high-confidence way to reproduce the issue? Yes at source level, but not live: current main only classifies auth text for extended timeouts while the PR-linked bug needs Teams/plugin selected-option context. I did not run a real Teams setup reproduction in this read-only review. Is this the best way to solve the issue? Yes, with a proof caveat: sharing option-aware timeout classification across WinUI and headless setup is the narrowest maintainable repair I found. Merge readiness still depends on live slow-path proof or a maintainer proof override. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 38fd2cf15e71. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Fixes #641.
Slow authentication, plugin installation, download, and Microsoft Teams setup operations now receive a five-minute RPC timeout in both WinUI and headless setup. Choice prompts only receive the longer timeout when the selected option is actually slow, so skip, Matrix, browser-labeled, and ordinary options keep the normal 30-second timeout.
Progress steps use their title, message, and step ID even when the gateway includes incidental options. This keeps WinUI and headless behavior aligned.
Credit to @ranjeshj for the original diagnosis and implementation direction in #648.
Validation
Native Windows 11 ARM64 VM, clean clone of current
mainplus this commit:./build.ps1— Shared, CLI, WinNode CLI, SetupEngine, and WinUI succeeded.dotnet test tests/OpenClaw.SetupEngine.Tests/OpenClaw.SetupEngine.Tests.csproj --no-restore --no-build— 429 passed.dotnet test tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore --no-build— 2,697 passed, 31 skipped.dotnet test tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore --no-build— 1,579 passed.Real behavior proof
Launched
run-app-local.ps1 -NoBuild -Isolatedin the Windows VM and exercised the real onboarding UI through local-gateway selection, confirmation, Standard capabilities, Windows permissions, and Install & set up. The app remained responsive and reached the real fresh WSL distribution creation step.Not verified / blocked: the Parallels guest cannot provide nested WSL2 virtualization. Gateway creation failed with
HCS_E_HYPERV_NOT_INSTALLED, so a real delayed Teams plugin operation could not be exercised in this VM. The actual >30-second Teams behavior remains blocked pending a physical or nested-virtualization-capable Windows host with a disposable Teams fixture; no live-pass claim is made here.