Redesign Hub title bar notifications and status#870
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 26, 2026, 9:18 PM ET / 01:18 UTC. Summary Reproducibility: yes. by source inspection: transition a manager snapshot from Connected or Ready to Degraded, or from Connecting to PairingRequired, without changing the mapped AppState.Status value. The Hub title-bar pill has no refresh trigger for that full snapshot change. Review metrics: 3 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Refresh the title-bar pill from full GatewayConnectionManager snapshot changes, keep the notification/banner action contract intact, and require active-notification runtime proof before merging the Hub chrome redesign. Do we have a high-confidence way to reproduce the issue? Yes by source inspection: transition a manager snapshot from Connected or Ready to Degraded, or from Connecting to PairingRequired, without changing the mapped AppState.Status value. The Hub title-bar pill has no refresh trigger for that full snapshot change. Is this the best way to solve the issue? No; the UI should observe the full GatewayConnectionManager state it displays instead of deriving a detailed pill from a coarse legacy AppState property. The flyout can still refresh on opening, but the always-visible pill needs live snapshot updates. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against acfbf62b4c45. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Move notifications from the footer rail into a title-bar bell flyout and replace the compact connection status dots with a status pill plus detail flyout. Keep the status presentation aligned with the Connection page by deriving node state from shared presenter logic and the node-mode/capability settings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
24a1367 to
0247641
Compare
Summary
Validation
./build.ps1dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore -- xUnit parallelizeTestCollections=falsedotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore -- xUnit parallelizeTestCollections=false