feat(calendar): show LOCATION column by default in events list#582
Open
gado-ships-it wants to merge 1 commit into
Open
feat(calendar): show LOCATION column by default in events list#582gado-ships-it wants to merge 1 commit into
gado-ships-it wants to merge 1 commit into
Conversation
The Calendar API populates `event.location` (a free-form place / address / venue string), but `calendar events` never surfaced it in the table view — users had to read JSON or open the event in another tool to find out where something happened. That made the listing meaningfully less useful for "plan the day" workflows, especially when an agent is generating context from the output. Add a LOCATION column after SUMMARY in every variant of the events list table — `--all` aggregated view, single calendar, with and without `--weekday`. JSON output already exposes `location` and is unchanged. eventDisplayLocation collapses embedded newlines, carriage returns, and tabs into single spaces so a multi-line postal address from the API does not break the row layout. Tests: new TestListCalendarEvents_TableIncludesLocation verifies the LOCATION header appears, that an event without a location renders as an empty cell, and that a location with an embedded newline is collapsed into a single line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event.location(the Calendar API field that holds the place / address / venue free-form string) was never rendered incalendar eventstable output. Reading the list in a terminal — or feeding it to an agent — required JSON output or a follow-upcalendar event getto learn where each thing was happening. For the "plan today" workflow this PR is aimed at, location is the most useful column after the time and the title.This PR adds a
LOCATIONcolumn afterSUMMARYin every table variant produced byrenderCalendarEventsTable:--allaggregated view (withCALENDARprefix)--weekdayeventDisplayLocationcollapses embedded\r\n,\n, and\tinto single spaces so multi-line postal addresses (which the Calendar UI happily accepts) do not split a row. JSON output already exposeslocationand is unchanged.Example (placeholder data):
Test plan
make fmtcleanmake lintcleanmake testgreenTestListCalendarEvents_TableIncludesLocationasserts theLOCATIONheader appears, an event without a location renders as an empty cell, and an embedded\nin the location is collapsed.🤖