Skip to content

perf: cache comment router label lookups#43

Closed
stainlu wants to merge 1 commit intoopenclaw:mainfrom
stainlu:stainlu/perf-comment-router-label-cache
Closed

perf: cache comment router label lookups#43
stainlu wants to merge 1 commit intoopenclaw:mainfrom
stainlu:stainlu/perf-comment-router-label-cache

Conversation

@stainlu
Copy link
Copy Markdown
Contributor

@stainlu stainlu commented May 5, 2026

Caches comment-router open-label issue lookups per process so autofix/automerge durable comment discovery and command synthesis do not repeat identical GitHub searches. Validation: build:repair, comment-router-core test, targeted oxlint, targeted oxfmt, git diff --check.

@steipete
Copy link
Copy Markdown
Contributor

steipete commented May 5, 2026

The label-lookup cache is a small, sensible reduction in repeated GitHub calls, but the branch is dirty against current main. Please rebase and rerun pnpm run check before this can land.

The important behavior to preserve is per-process caching with copied return arrays, so callers cannot mutate cached state between lookups.

@stainlu stainlu force-pushed the stainlu/perf-comment-router-label-cache branch from 21d661b to 7637e06 Compare May 5, 2026 08:04
@stainlu
Copy link
Copy Markdown
Contributor Author

stainlu commented May 5, 2026

Rebased on current main and reran pnpm run check under Node 24. The cache still returns copied arrays so callers cannot mutate cached label-number state.

@steipete
Copy link
Copy Markdown
Contributor

steipete commented May 5, 2026

Landed this manually after resolving the shared CHANGELOG.md conflict from the capacity-probe PR. The implementation and regression test stayed intact.

Landed on main: ec1ea902a3

Thanks @stainlu.

@steipete steipete closed this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants