Skip to content

fix(docs): authorization deny precedence docs - #811

Merged
mevan-karu merged 1 commit into
openchoreo:mainfrom
mevan-karu:fix/authz-deny-precedence-docs
Aug 10, 2026
Merged

fix(docs): authorization deny precedence docs#811
mevan-karu merged 1 commit into
openchoreo:mainfrom
mevan-karu:fix/authz-deny-precedence-docs

Conversation

@mevan-karu

Copy link
Copy Markdown
Contributor

$subject

Related Issues

openchoreo/openchoreo#4446

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@mevan-karu, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fab5cb8b-bdaa-4796-b803-29743946ad72

📥 Commits

Reviewing files that changed from the base of the PR and between 3fb220a and 3d3247e.

⛔ Files ignored due to path filters (11)
  • versioned_docs/version-v1.0.x/platform-engineer-guide/authorization/overview.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.0.x/reference/api/platform/authzrolebinding.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.0.x/reference/api/platform/clusterauthzrolebinding.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.1.x/platform-engineer-guide/authorization/conditions.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.1.x/platform-engineer-guide/authorization/overview.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.1.x/reference/api/platform/authzrolebinding.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.1.x/reference/api/platform/clusterauthzrolebinding.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.2.x/platform-engineer-guide/authorization/conditions.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.2.x/platform-engineer-guide/authorization/overview.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.2.x/reference/api/platform/authzrolebinding.md is excluded by !versioned_docs/**
  • versioned_docs/version-v1.2.x/reference/api/platform/clusterauthzrolebinding.md is excluded by !versioned_docs/**
📒 Files selected for processing (4)
  • docs/platform-engineer-guide/authorization/conditions.md
  • docs/platform-engineer-guide/authorization/overview.md
  • docs/reference/api/platform/authzrolebinding.md
  • docs/reference/api/platform/clusterauthzrolebinding.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The authorization docs described `effect: deny` as a global override
that blocks a request whenever any matching binding denies it. The
engine evaluates once per entitlement value and applies deny only
within the entitlement it is bound to, so a user who belongs to both an
allowed group and a denied group is allowed.

The API reference went further and recommended deny as the mechanism
for revoking access, which does not work when the grant comes from a
different entitlement.

Describe the aggregation rule as per-entitlement resolution followed by
a union across entitlements, note that deny is scoped to its binding
subject rather than to a person, and add a "Revoking access" section
covering the supported way to remove access: remove the granting
binding or narrow its scope.

Applied in full to docs/ and v1.2.x. v1.1.x and v1.0.x receive the
wording corrections only, without the new section or callout, to keep
the archived versions structurally unchanged. v0.16.x and v0.17.x still
carry the old text and are left for a separate decision.\

Signed-off-by: Mevan <mevan.karu@gmail.com>
@mevan-karu
mevan-karu force-pushed the fix/authz-deny-precedence-docs branch from 3c0933b to 3d3247e Compare August 7, 2026 06:22
@mevan-karu mevan-karu changed the title Fix/authz deny precedence docs fix(docs): deny precedence docs Aug 7, 2026
@mevan-karu mevan-karu changed the title fix(docs): deny precedence docs fix(docs): authorization deny precedence docs Aug 7, 2026

@LakshanSS LakshanSS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mevan-karu
mevan-karu merged commit 5fce274 into openchoreo:main Aug 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants