chore: fix doublequote string style violations in first-party JavaScript#722
Open
anonymoususer72041 wants to merge 1 commit intoopencats:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
Strings must use doublequote.violations across first-party JavaScript files in the repository.The changes are intentionally minimal and limited to quote-style normalization. The goal is to satisfy the Codacy rule without changing runtime behavior, restructuring code or mixing in unrelated cleanup.
Only first-party JavaScript files were updated. Vendored, generated, bundled and otherwise unrelated files were not touched.
This PR also deliberately avoids forcing additional changes in ambiguous legacy cases where a quote conversion would make the code less readable or increase the risk of changing semantics. In particular, JavaScript code assembled as strings was left out when the conversion would mainly introduce extra escaping without a clear quality benefit.
Overall, this keeps the patch focused, mechanical and easy to review while improving consistency with the configured string-style rule.