Skip to content

feat: treat NULL install schema version as snapshot #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonymoususer72041 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: treat NULL install schema version as snapshot #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a307500
Treat NULL install module_schema version as schema snapshot
anonymoususer72041 Feb 20, 2026
8995625
Omit install module_schema version from cats_schema.sql
anonymoususer72041 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db/cats_schema.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ insert into `module_schema`(`module_schema_id`,`name`,`version`) values (9,'ext
insert into `module_schema`(`module_schema_id`,`name`,`version`) values (10,'graphs',0);
insert into `module_schema`(`module_schema_id`,`name`,`version`) values (11,'home',0);
insert into `module_schema`(`module_schema_id`,`name`,`version`) values (12,'import',0);
insert into `module_schema`(`module_schema_id`,`name`,`version`) values (13,'install',370);
insert into `module_schema`(`module_schema_id`,`name`) values (13,'install');
insert into `module_schema`(`module_schema_id`,`name`,`version`) values (14,'joborders',0);
insert into `module_schema`(`module_schema_id`,`name`,`version`) values (15,'lists',0);
insert into `module_schema`(`module_schema_id`,`name`,`version`) values (16,'login',0);
Expand Down
20 changes: 20 additions & 0 deletions lib/ModuleUtility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,26 @@ private static function processModuleSchema($moduleName, $schema)
$newestVersion = 0;
}

if ($moduleName === 'install' && ($currentVersion === NULL || $currentVersion === ''))
{
/* A NULL version indicates a schema snapshot install (cats_schema.sql).
* Mark the install module as up-to-date to avoid re-running migrations.
*/
$sql = sprintf(
"UPDATE
module_schema
SET
version = %s
WHERE
name = %s",
(int) $newestVersion,
$db->makeQueryString($moduleName)
);
$db->query($sql);

return;
}

/* Do we have any updates to process? */
if ($newestVersion <= $currentVersion)
{
Expand Down
Loading