feat: Add REST API Module and Tearsheets Feature #703
426 new issues (0 max.) of at least severity.
Here is an overview of what got changed by this pull request:
Issues
======
- Added 426
Complexity increasing per file
==============================
- src/OpenCATS/Tests/UnitTests/ResultSetUtilityTest.php 1
- modules/calendar/CalendarUI.php 96
- lib/DocumentToText.php 85
- modules/install/scripts/150.php 9
- src/OpenCATS/Tests/IntegrationTests/DatabaseConnectionTest.php 14
- lib/Questionnaire.php 73
- modules/export/ExportUI.php 13
- lib/Tags.php 20
- modules/queue/tasks/SampleTask.php 4
- src/OpenCATS/Tests/UnitTests/VCardTest.php 5
- optional-updates/latest-sphinx-search/Search.php 120
- lib/Wizard.php 6
- lib/Companies.php 40
- lib/Mailer.php 31
- js/suggest.js 13
- lib/artichow/Artichow.class.php 31
- lib/DatabaseConnection.php 74
- lib/ControlPanel.php 381
- src/OpenCATS/Entity/JobOrder.php 44
- lib/WebForm.php 223
- lib/Dashboard.php 14
- lib/Display.php 20
- src/OpenCATS/Tests/IntegrationTests/DatabaseTestCase.php 13
- modules/lists/ListsUI.php 37
- modules/candidates/dataGrids.php 9
- modules/graphs/GraphsUI.php 69
- lib/artichow/inc/Axis.class.php 88
- lib/JobOrderStatuses.php 17
- lib/JavaScriptCompressor.php 4
- src/OpenCATS/Tests/UnitTests/BrowserDetectionTest.php 2
- lib/Graphs.php 22
- modules/queue/tasks/SampleRecurring.php 5
- lib/SystemInfo.php 6
- modules/install/Schema.php 1
- lib/FileUtility.php 91
- modules/candidates/validator.js 36
- lib/CBFUtility.php 103
- lib/simpletest/test/visual_test.php 78
- lib/simpletest/test/eclipse_test.php 1
- lib/EmailTemplates.php 27
- modules/candidates/CandidatesUI.php 414
- lib/InstallationTests.php 133
- js/lists.js 41
- lib/simpletest/eclipse.php 48
- js/quickAction.js 19
- modules/import/ImportUI.php 332
- src/OpenCATS/Entity/CompanyRepository.php 5
- modules/settings/ajax/backup.php 2
- lib/ModuleUtility.php 59
- lib/QueueProcessor.php 87
- modules/companies/CompaniesUI.php 130
- modules/home/dataGrids.php 15
- lib/StringUtility.php 120
- lib/Session.php 140
- scripts/makeBackup.php 25
- index.php 2
- lib/DatabaseSearch.php 27
- lib/LoginActivity.php 10
- lib/Users.php 78
- lib/fpdf/font/makefont/makefont.php 70
- modules/import/Import.php 23
- modules/install/ajax/ui.php 12
- lib/CandidatesImport.php 3
- src/OpenCATS/Tests/UnitTests/CompanyRepositoryTest.php 7
- lib/SystemUtility.php 7
- lib/CompaniesImport.php 3
- lib/ZipLookup.php 13
- lib/XmlJobExport.php 19
- lib/Statistics.php 38
- modules/tests/testcases/WebTests.php 14
- test/features/bootstrap/FeatureContext.php 50
- modules/candidates/quickAction-duplicates.js 4
- modules/candidates/quickAction-candidates.js 3
- src/OpenCATS/Tests/UnitTests/AddressParserTest.php 24
- src/OpenCATS/Tests/IntegrationTests/DatabaseSearchTest.php 3
- src/OpenCATS/Tests/UnitTests/AJAXInterfaceTest.php 9
- lib/artichow/inc/Label.class.php 75
- lib/Calendar.php 61
- modules/activity/ActivityUI.php 30
- lib/LDAP.php 22
- modules/careers/CareersUI.php 2
- lib/Profile.php 148
- lib/TemplateUtility.php 138
- lib/Contacts.php 35
- modules/queue/tasks/CleanExceptions.php 4
- modules/wizard/WizardUI.php 28
- modules/contacts/dataGrids.php 4
- lib/AddressParser.php 92
- modules/tests/TestsUI.php 10
- modules/tests/testcases/AJAXTests.php 23
- lib/fpdf/fpdf.php 291
- lib/DataGrid.php 320
- lib/CommonErrors.php 32
- lib/FileCompressor.php 79
- src/OpenCATS/Tests/UnitTests/StringUtilityTest.php 30
- modules/install/CATSUI.php 2
- modules/lists/ajax/addToLists.php 6
- modules/calendar/tasks/Reminders.php 11
- ajax/getPipelineJobOrder.php 7
- lib/Search.php 85
- js/emailHandler.js 41
- rebuild_old_docs.php 4
- lib/ImportableEntity.php 4
- modules/lists/dataGrids.php 5
- lib/artichow/Graph.class.php 32
- src/OpenCATS/Tests/UnitTests/FileUtilityTest.php 3
- lib/GraphGenerator.php 23
- lib/simpletest/detached.php 9
- modules/home/HomeUI.php 45
- modules/install/backupDB.php 59
- modules/login/LoginUI.php 75
- modules/attachments/AttachmentsUI.php 13
- modules/rss/RssUI.php 3
- lib/JobOrders.php 47
- src/OpenCATS/Tests/UnitTests/DateUtilityTest.php 8
- lib/Pipelines.php 27
- modules/xml/XmlUI.php 3
- lib/ListEditor.php 33
- lib/CATSUtility.php 47
- lib/ActivityEntries.php 28
- lib/DefaultQuestionnaires.php 2
- modules/companies/dataGrids.php 4
- src/OpenCATS/Entity/JobOrderRepository.php 6
- modules/activity/dataGrids.php 11
- modules/joborders/JobOrdersUI.php 225
- lib/Candidates.php 143
- lib/Export.php 7
- modules/reports/ReportsUI.php 66
- lib/DateUtility.php 76
- lib/ContactsImport.php 3
- lib/CareerPortal.php 22
- lib/UserInterface.php 55
- modules/contacts/ContactsUI.php 165
- lib/ImportUtility.php 10
- lib/Attachments.php 95
- modules/install/scripts/114.php 14
- src/OpenCATS/UI/CandidateDuplicateQuickActionMenu.php 3
- modules/toolbar/ToolbarUI.php 39
- modules/api/handlers/MassUpdateHandler.php 30
- modules/api/handlers/MetaHandler.php 8
- modules/api/handlers/TaskHandler.php 120
- lib/WebhookSubscription.php 56
- test/security/webhook_audit.php 122
- lib/NewVersionCheck.php 17
- src/OpenCATS/UI/QuickActionMenu.php 8
- src/OpenCATS/Tests/UnitTests/ArrayUtilityTest.php 1
- lib/License.php 112
- modules/joborders/dataGrids.php 6
- js/ckeditor-manager.js 5
- lib/ExtraFields.php 77
- modules/api/handlers/SubscriptionHandler.php 80
- modules/api/handlers/CandidateHandler.php 142
- modules/api/handlers/AppointmentHandler.php 92
- test/quality/code_style_audit.php 28
- modules/api/handlers/OAuthHandler.php 111
- test/functional/api_response_test.php 126
- test/security/sql_injection_audit.php 83
- modules/api/handlers/CompanyHandler.php 98
- test/security/input_validation_audit.php 99
- modules/api/handlers/JobOrderHandler.php 124
- modules/api/handlers/AttachmentHandler.php 113
- lib/Notes.php 43
- lib/ApiRequestLogger.php 16
- modules/api/handlers/PlacementHandler.php 151
- lib/ApiRateLimiter.php 13
- lib/ApiKeys.php 40
- modules/api/handlers/JobSubmissionHandler.php 76
- modules/api/handlers/AssociationHandler.php 64
- modules/api/formatters/EntityFormatter.php 439
- test/functional/crud_completeness_audit.php 47
- test/security/rate_limit_audit.php 66
- lib/Placements.php 53
- lib/JobSubmissions.php 46
- lib/Tearsheets.php 39
- lib/Appointments.php 57
- test/integration/oauth_flow_test.php 58
- lib/OAuth2Server.php 41
- test/quality/error_handling_audit.php 65
- modules/api/ApiUI.php 103
- test/integration/webhook_validation.php 34
- lib/Tasks.php 61
- lib/WebhookDispatcher.php 31
- test/security/auth_audit.php 103
- modules/api/handlers/TearsheetHandler.php 81
- test/compliance/audit_logging_validation.php 42
- test/compliance/pii_audit.php 131
- modules/api/handlers/NoteHandler.php 51
- modules/api/traits/WebhookTrigger.php 5
- modules/api/handlers/ContactHandler.php 126
- modules/api/traits/ApiHelpers.php 51
- lib/ApiResponse.php 4
Clones added
============
- js/suggest.js 3
- modules/candidates/validator.js 8
- js/lists.js 49
- js/emailHandler.js 2
See the complete overview on Codacy
Annotations
Check notice on line 5 in js/ckeditor-manager.js
codacy-production / Codacy Static Code Analysis
js/ckeditor-manager.js#L5
Strings must use doublequote.
Check notice on line 9 in js/ckeditor-manager.js
codacy-production / Codacy Static Code Analysis
js/ckeditor-manager.js#L9
Strings must use doublequote.
Check warning on line 13 in js/ckeditor-manager.js
codacy-production / Codacy Static Code Analysis
js/ckeditor-manager.js#L13
The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.
Check warning on line 59 in lib/ApiKeys.php
codacy-production / Codacy Static Code Analysis
lib/ApiKeys.php#L59
Avoid using static access to class 'DatabaseConnection' in method '__construct'.
Check warning on line 129 in lib/ApiRequestLogger.php
codacy-production / Codacy Static Code Analysis
lib/ApiRequestLogger.php#L129
_getClientIP accesses the super-global variable $_SERVER.
Check warning on line 160 in lib/ApiRequestLogger.php
codacy-production / Codacy Static Code Analysis
lib/ApiRequestLogger.php#L160
Avoid using static access to class 'DatabaseConnection' in method 'cleanup'.
Check warning on line 45 in lib/Appointments.php
codacy-production / Codacy Static Code Analysis
lib/Appointments.php#L45
The class Appointments has an overall complexity of 57 which is very high. The configured complexity threshold is 50.
Check warning on line 93 in lib/Appointments.php
codacy-production / Codacy Static Code Analysis
lib/Appointments.php#L93
The method add() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
Check warning on line 93 in lib/Appointments.php
codacy-production / Codacy Static Code Analysis
lib/Appointments.php#L93
The method add() has an NPath complexity of 24576. The configured NPath complexity threshold is 200.
Check warning on line 1310 in lib/Candidates.php
codacy-production / Codacy Static Code Analysis
lib/Candidates.php#L1310
The method mergeDuplicates() has an NPath complexity of 37791360. The configured NPath complexity threshold is 200.
Check notice on line 55 in lib/JobOrderStatuses.php
codacy-production / Codacy Static Code Analysis
lib/JobOrderStatuses.php#L55
Avoid excessively long variable names like $_defaultStatisticsStatuses. Keep variable name length under 20.
Check warning on line 617 in lib/JobOrders.php
codacy-production / Codacy Static Code Analysis
lib/JobOrders.php#L617
Avoid using static access to class 'JobOrderStatuses' in method 'getAll'.
Check warning on line 71 in lib/JobSubmissions.php
codacy-production / Codacy Static Code Analysis
lib/JobSubmissions.php#L71
Avoid using static access to class 'DatabaseConnection' in method '__construct'.
Check warning on line 362 in lib/Notes.php
codacy-production / Codacy Static Code Analysis
lib/Notes.php#L362
The method update() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
Check warning on line 618 in lib/OAuth2Server.php
codacy-production / Codacy Static Code Analysis
lib/OAuth2Server.php#L618
Avoid using static access to class 'DatabaseConnection' in method 'cleanup'.
Check warning on line 108 in lib/Statistics.php
codacy-production / Codacy Static Code Analysis
lib/Statistics.php#L108
Avoid using static access to class 'JobOrderStatuses' in method 'getSubmissionCount'.
Check warning on line 38 in lib/Tasks.php
codacy-production / Codacy Static Code Analysis
lib/Tasks.php#L38
The class Tasks has an overall complexity of 60 which is very high. The configured complexity threshold is 50.
Check warning on line 386 in lib/Tasks.php
codacy-production / Codacy Static Code Analysis
lib/Tasks.php#L386
The method update() has 133 lines of code. Current threshold is set to 100. Avoid really long methods.
Check warning on line 39 in lib/Tearsheets.php
codacy-production / Codacy Static Code Analysis
lib/Tearsheets.php#L39
The class Tearsheets has 13 non-getter- and setter-methods. Consider refactoring Tearsheets to keep number of methods under 10.
Check warning on line 52 in lib/Tearsheets.php
codacy-production / Codacy Static Code Analysis
lib/Tearsheets.php#L52
Avoid using static access to class 'DatabaseConnection' in method '__construct'.
Check notice on line 92 in lib/WebhookDispatcher.php
codacy-production / Codacy Static Code Analysis
lib/WebhookDispatcher.php#L92
Avoid excessively long variable names like $queuedSubscriptionIDs. Keep variable name length under 20.
Check warning on line 159 in lib/WebhookDispatcher.php
codacy-production / Codacy Static Code Analysis
lib/WebhookDispatcher.php#L159
The method dispatchWebhook() has 117 lines of code. Current threshold is set to 100. Avoid really long methods.
Check warning on line 419 in lib/WebhookDispatcher.php
codacy-production / Codacy Static Code Analysis
lib/WebhookDispatcher.php#L419
Avoid using static access to class 'DatabaseConnection' in method 'updateQueueSchedule'.
Check warning on line 114 in modules/api/ApiUI.php
codacy-production / Codacy Static Code Analysis
modules/api/ApiUI.php#L114
The method handleRequest() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10.
Check warning on line 128 in modules/api/ApiUI.php
codacy-production / Codacy Static Code Analysis
modules/api/ApiUI.php#L128
The method handleRequest() contains an exit expression.