Repository navigation
Conversation
The Dallas Fed renamed the survey workbooks' sheet from Index to Sheet1. The sheet is picked by name from either, then the only sheet, as dallas_bcs already does. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…survey workbooks dallas_tmos, dallas_tssos and dallas_bcs each carried a copy of the same sheet-picking block. It is now survey_sheet() in utils/dallas_survey.py: the first published name present, else the only sheet, else an error that names the sheets found. dallas_bcs used to fall back to its old sheet name and fail inside pandas; it now raises that same error. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Dallas Fed manufacturing (TMOS) and service-sector (TSSOS) surveys fail with
The Dallas Fed renamed the sheet in both workbooks from
IndextoSheet1(seen 2026-11-17).Change
utils/dallas_survey.py: newsurvey_sheet(content, names). It returns the first of the published names the workbook has, else the workbook's only sheet. If none matches in a workbook of several sheets, it raises anOpenBBErrorthat names the sheets it found.dallas_tmos.pyanddallas_tssos.pycall it with("Index", "Sheet1").dallas_bcs.pyhad its own copy of this selection, forCSV_BCS_Index_ResultsandBCS_Index_Results. It now calls the same helper. One difference: with several sheets and no match it used to fall back to the old name and fail inside pandas; it now raises the helper's error.Tests
test_survey_sheet_named_index_or_sheet1, for both fetchers and both sheet names. The twoSheet1cases fail ondevelop.TestSurveySheet: a listed name wins in order, a single sheet is used whatever its name, and no match among several sheets raises with their names.openbb_platform/providers/federal_reserve/tests: 2,408 passed (Python 3.12).🤖 Generated with Claude Code