Skip to content

fix(federal_reserve): Dallas TMOS and TSSOS read the renamed sheet - #7848

Open
artcashin wants to merge 2 commits into
openbq-org:developfrom
artcashin:fix/dallas-survey-sheet-renamed
Open

artcashin wants to merge 2 commits into
openbq-org:developfrom
artcashin:fix/dallas-survey-sheet-renamed

Conversation

@artcashin

@artcashin artcashin commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem

The Dallas Fed manufacturing (TMOS) and service-sector (TSSOS) surveys fail with

Worksheet named 'Index' not found

The Dallas Fed renamed the sheet in both workbooks from Index to Sheet1 (seen 2026-11-17).

Change

  • utils/dallas_survey.py: new survey_sheet(content, names). It returns the first of the published names the workbook has, else the workbook's only sheet. If none matches in a workbook of several sheets, it raises an OpenBBError that names the sheets it found.
  • dallas_tmos.py and dallas_tssos.py call it with ("Index", "Sheet1").
  • dallas_bcs.py had its own copy of this selection, for CSV_BCS_Index_Results and BCS_Index_Results. It now calls the same helper. One difference: with several sheets and no match it used to fall back to the old name and fail inside pandas; it now raises the helper's error.

Tests

  • test_survey_sheet_named_index_or_sheet1, for both fetchers and both sheet names. The two Sheet1 cases fail on develop.
  • New TestSurveySheet: a listed name wins in order, a single sheet is used whatever its name, and no match among several sheets raises with their names.
  • openbb_platform/providers/federal_reserve/tests: 2,408 passed (Python 3.12).

🤖 Generated with Claude Code

artcashin and others added 2 commits November 18, 2026 03:28
The Dallas Fed renamed the survey workbooks' sheet from Index to Sheet1. The sheet is picked by name from either, then the only sheet, as dallas_bcs already does.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…survey workbooks

dallas_tmos, dallas_tssos and dallas_bcs each carried a copy of the same
sheet-picking block. It is now survey_sheet() in utils/dallas_survey.py:
the first published name present, else the only sheet, else an error that
names the sheets found. dallas_bcs used to fall back to its old sheet name
and fail inside pandas; it now raises that same error.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant