ci: bump GitHub Actions off the deprecated Node 20 runtime - #167
Open
fullstackjam wants to merge 1 commit into
Open
fullstackjam wants to merge 1 commit into
fullstackjam wants to merge 1 commit into
Conversation
main CI already warns that checkout@v4, setup-go@v5 and
golangci-lint-action@v7 target Node 20 and are being forced onto
Node 24. Move every action to its current major, all of which run on
node24 (codecov is a composite action):
checkout v4->v7, setup-go v5->v7, upload-artifact v4->v7,
download-artifact v4->v8, github-script v7->v9, labeler v5->v7,
codecov-action v4->v7, golangci-lint-action v7->v9,
action-gh-release v2->v3
Breaking changes reviewed against our usage, none require edits:
- checkout v7 refuses fork-PR checkout under pull_request_target /
workflow_run: drift-to-issue checks out the default ref; labeler
does not check out.
- checkout v6 moves persisted creds to $RUNNER_TEMP: the upstream
README says git push needs no change (auto-release tag push,
homebrew-tap push).
- github-script v9 breaks require('@actions/github'): issue-greeting
does not use it.
- download-artifact v5 changes by-ID single downloads; v8 errors on
digest mismatch: release.yml downloads all artifacts by name.
- codecov v5 deprecates `file`: we already use `files`.
Every `with:` input we pass exists in the new action.yml; actionlint
is clean.
4 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves every GitHub Action in
.github/workflows/to its current major version. Each new version runs on Node 24.Why?
main CI currently emits this warning:
Testing
I read each skipped major's breaking changes against how we use the action. None require workflow edits:
pull_request_target/workflow_rundrift-to-issue(workflow_run) checks out the default ref.labeler(pull_request_target) does not check out code.$RUNNER_TEMPgit pushneeds no change. Affected steps: the auto-release tag push and the homebrew-tap push.require('@actions/github')failsissue-greetinguses neitherrequirenorgetOctokit.release.ymldownloads all artifacts by name. The by-ID change doesn't apply.filefiles.with:input we pass (25 of them) exists in the new version'saction.ymlactionlint: cleanruns.using: node24(codecov is composite)Cross-repo checklist
openboot.dev? NoNotes for reviewer
This PR's CI can't verify these workflows, because they only run on their own triggers:
release.yml: upload/download artifacts, gh-release, and the homebrew-tap pushauto-release.yml: tag pushlabeler.yml,issue-greeting.yml,drift-to-issue.yml,validate-catalog.ymlclaude.ymlThe first real release after merge is where to watch. A manual
workflow_dispatchofrelease.ymlwould exercise it earlier, but it publishes a real release.This PR is independent of #166 (the Go 1.26.8 bump).