First logout the user and only then show the alert#2
Open
Turrentianos wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alert was pausing the script which could cause the user to be logged out after just logging in. Concretely if you have multiple tabs open and your session expires then a pop up is shown in all the open redmine tabs. From this state two issues can occur:
These two problems are caused because the alert actually halts the execution of the script. This caused the script to only log out the user after they press okay on the alert.
This pr solves the described problems by first logging the user out (in another iframe) and then showing the alert. If the page is not refreshed the alert is shown again after 1 hour.