Skip to content

chore(api): document fine-tuning and model errors - #764

Merged
markstuart-oai merged 1 commit into
mainfrom
castiron/promotions/pr-158
Sep 25, 2026
Merged

markstuart-oai merged 1 commit into
mainfrom
castiron/promotions/pr-158

Conversation

@markstuart-oai

Copy link
Copy Markdown
Contributor

Summary

Clarifies fine-tuning and model error responses while retaining existing Ruby behavior.

Changes

  • Describe applicable validation, lookup, permission and rate-limit errors.
  • Preserve existing methods and exception behavior.

Castiron-Internal-PR: openai/openai-ruby-internal#158
Castiron-Source-SHA: 5753ef6855a3dd6c6bb4a2b00f037d31a64ca9e2
Castiron-Public-Base-SHA: ddd1a68
@markstuart-oai
markstuart-oai marked this pull request as ready for review September 25, 2026 19:20
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 25, 2026 19:20
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

70 mixed files remain; 0 existing customizations changed.

Compared ddd1a68179ad → b467ae8e88f3. Generated baselines verified.

70 existing customizations unchanged
  • lib/openai.rb
  • lib/openai/client.rb
  • lib/openai/models/audio/transcription_create_response.rb
  • lib/openai/models/beta/agents/vault_status_filter.rb
  • lib/openai/models/chat/chat_completion_message.rb
  • lib/openai/models/chat/chat_completion_message_function_tool_call.rb
  • lib/openai/models/chat/completion_create_params.rb
  • lib/openai/models/image_edit_completed_event.rb
  • lib/openai/models/image_edit_partial_image_event.rb
  • lib/openai/models/image_gen_completed_event.rb
  • lib/openai/models/image_gen_partial_image_event.rb
  • lib/openai/models/images_response.rb
  • lib/openai/models/response_format_json_schema.rb
  • lib/openai/models/responses/function_tool.rb
  • lib/openai/models/responses/response.rb
  • lib/openai/models/responses/response_create_params.rb
  • lib/openai/models/responses/response_format_text_config.rb
  • lib/openai/models/responses/response_format_text_json_schema_config.rb
  • lib/openai/models/responses/response_function_tool_call.rb
  • lib/openai/models/responses/response_function_web_search.rb
  • lib/openai/models/responses/response_output_text.rb
  • lib/openai/models/responses/tool.rb
  • lib/openai/models/webhooks/webhook_endpoint_with_secret.rb
  • lib/openai/resources/beta/agents/sessions.rb
  • lib/openai/resources/beta/threads.rb
  • lib/openai/resources/chat/completions.rb
  • lib/openai/resources/containers/files.rb
  • lib/openai/resources/files.rb
  • lib/openai/resources/responses.rb
  • lib/openai/resources/vector_stores/file_batches.rb
  • lib/openai/resources/vector_stores/files.rb
  • lib/openai/resources/webhooks.rb
  • rbi/openai/client.rbi
  • rbi/openai/models/beta/agents/vault_status_filter.rbi
  • rbi/openai/models/chat/chat_completion_message.rbi
  • rbi/openai/models/chat/chat_completion_message_function_tool_call.rbi
  • rbi/openai/models/chat/completion_create_params.rbi
  • rbi/openai/models/image_edit_completed_event.rbi
  • rbi/openai/models/image_edit_partial_image_event.rbi
  • rbi/openai/models/image_gen_completed_event.rbi

30 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 36179086840 --repo openai/openai-ruby \
  --name castiron-custom-code-36179086840-1 --dir /tmp/castiron-custom-code-36179086840-1
git apply --stat /tmp/castiron-custom-code-36179086840-1/custom-code.patch
cat /tmp/castiron-custom-code-36179086840-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin ddd1a68179ad1ec90af55f39f71310a59f92ddcf b467ae8e88f36789b20090938ad7659ba8b94e69
python3 scripts/castiron/custom_code_report.py report \
  --base ddd1a68179ad1ec90af55f39f71310a59f92ddcf \
  --head b467ae8e88f36789b20090938ad7659ba8b94e69 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-b467ae8e88f3
cat /tmp/castiron-custom-code-b467ae8e88f3/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@openai-sdks

openai-sdks Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

OkTest Summary

✅ 236/236 SDK tests passed in 8.257s for Ruby SDK PR #764.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 134ms
tests/chat-completions-create.test.ts ✅ Passed 216ms
tests/chat-completions-stream.test.ts ✅ Passed 122ms
tests/files-content-binary.test.ts ✅ Passed 129ms
tests/files-create-multipart.test.ts ✅ Passed 155ms
tests/files-list-pagination.test.ts ✅ Passed 145ms
tests/initialize-config.test.ts ✅ Passed 94ms
tests/instance-isolation.test.ts ✅ Passed 103ms
tests/models-list.test.ts ✅ Passed 121ms
tests/responses-background-lifecycle.test.ts ✅ Passed 151ms
tests/responses-body-method-errors.test.ts ✅ Passed 365ms
tests/responses-cancel-timeout.test.ts ✅ Passed 208ms
tests/responses-cancel.test.ts ✅ Passed 231ms
tests/responses-compact-retries.test.ts ✅ Passed 128ms
tests/responses-compact.test.ts ✅ Passed 208ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 154ms
tests/responses-create-advanced.test.ts ✅ Passed 147ms
tests/responses-create-disconnect.test.ts ✅ Passed 124ms
tests/responses-create-errors.test.ts ✅ Passed 344ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 113ms
tests/responses-create-retries.test.ts ✅ Passed 172ms
tests/responses-create-stream-failures.test.ts ✅ Passed 120ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 204ms
tests/responses-create-stream-wire.test.ts ✅ Passed 1.813s
tests/responses-create-stream.test.ts ✅ Passed 128ms
tests/responses-create-terminal-states.test.ts ✅ Passed 225ms
tests/responses-create-timeout.test.ts ✅ Passed 206ms
tests/responses-create.test.ts ✅ Passed 142ms
tests/responses-delete.test.ts ✅ Passed 111ms
tests/responses-input-items-errors.test.ts ✅ Passed 158ms
tests/responses-input-items-list.test.ts ✅ Passed 166ms
tests/responses-input-items-options.test.ts ✅ Passed 93ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 219ms
tests/responses-input-tokens-count.test.ts ✅ Passed 128ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.077s
tests/responses-not-found-errors.test.ts ✅ Passed 286ms
tests/responses-parse.test.ts ✅ Passed 123ms
tests/responses-retrieve-retries.test.ts ✅ Passed 241ms
tests/responses-retrieve.test.ts ✅ Passed 166ms
tests/responses-stored-method-errors.test.ts ✅ Passed 613ms
tests/retry-behavior.test.ts ✅ Passed 3.382s
tests/sdk-error-shape.test.ts ✅ Passed 457ms

View OkTest run #36179054330

SDK merge (ef6e98e1cbba) · head (b467ae8e88f3) · base (ddd1a68179ad) · OkTest (f9111d4e2fcd)

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed b467ae8. No findings.

The complete diff is limited to the API-reference YAML and generation metadata. Both schema Git blobs match the immutable base/head pair I fully parsed and validated for the corresponding Python/TypeScript changes: exactly 38 error-response additions across 16 fine-tuning/grader/model operations, all new references resolving, no duplicate YAML keys, and all other semantic content unchanged. The transformed-spec hash matches the reviewed artifact; only the five expected generation/provenance metadata fields changed.

Public methods, exception handling, runtime code, types, dependencies, tests, workflows, and custom-code budget policy are unchanged. Exact-head repository CI is green, including Ruby 3.3/3.4/4.0, Bedrock, RBS/RBI, packaging, lint, and baseline/budget checks. OkTest run 36179054330 completed successfully and its head/base-pinned summary reports 236/236 passing cases.

I reused verified content-addressed schema validation and checked this PR's metadata and CI independently; I did not run local Ruby workloads or live API calls.

@markstuart-oai
markstuart-oai added this pull request to the merge queue Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for the exact-head review, including the independent metadata and Ruby CI checks. The reviewed head b467ae8 remains unchanged. Only the reference and metadata differ; methods, exception handling, and runtime code are preserved. The passing 236-case downstream run and full-tree comparison support no user-code migration for this update; no further change is needed for this review.

Merged via the queue into main with commit 4b3b043 Sep 25, 2026
22 checks passed
@markstuart-oai
markstuart-oai deleted the castiron/promotions/pr-158 branch September 25, 2026 19:42
@openai-sdks openai-sdks Bot mentioned this pull request Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants